-
Notifications
You must be signed in to change notification settings - Fork 146
docs: add reshopInfo field to rate details criteria #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: add reshopInfo field to rate details criteria #1412
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to update several other places:
- Schema documentation for RateDetailsCritera: https://developer.concur.com/api-reference/direct-connects/hotel-service-4/v4.schemas.html#-ratedetailscriteria
- Add another example of rate-details endpoint (https://developer.concur.com/api-reference/direct-connects/hotel-service-4/v4.endpoints.html#rate-details-) for modify feature.
}, | ||
"reshopInfo": { | ||
"description": "Contains information required for reshopping a hotel booking.", | ||
"recordLocator": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use existing type GDSRecordLocator
"description": "The PIN associated with the booking for additional security.", | ||
"type": "string" | ||
}, | ||
"posId": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not required, remove this.
"type": "string" | ||
} | ||
}, | ||
"confirmationNumber": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use confirmationCodes with array of confirmationCodeType just like we have in ModifyCriteria here: https://developer.concur.com/api-reference/direct-connects/hotel-service-4/v4.schemas.html#schemamodifycriteria
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case we can also remove the pin object to add it in as one of the entries of the confirmationCodes array. There is a confirmationCodeType PIN
already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see you defining #schemareshopinfo - which should link to Reshop schema details in v4.schemas.markdown
@@ -407,7 +407,18 @@ POST /hotels/ratedetails | |||
], | |||
"numGuests": 1, | |||
"guestCountryCode": "CA", | |||
"searchSessionToken": "b41168ba-7ee1-4b68-9934-47f5c55337d6" | |||
"searchSessionToken": "b41168ba-7ee1-4b68-9934-47f5c55337d6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be better to have two separate examples, first one as it was earlier (titled rate-details during shopping flow) and new example titled rate-details during modify/reshop flow)
@@ -61,6 +61,7 @@ Reference to location details for search. | |||
`numGuests`|`integer`|`int32`|Number of guests for accommodation.| | |||
`guestCountryCode`|`string`|`ISO ALPHA-2`|Two-character ISO code for country.| | |||
`searchSessionToken`|[`SearchSessionToken`](#schemasearchsessiontoken)|-|Session token to be generated and provided by server on initial search call that can be referenced back for future calls on the same session.| | |||
`reshopInfo`|[`ReshopInfo`](#schemareshopinfo)|-|Information related to reshopping, if applicable.| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`reshopInfo`|[`ReshopInfo`](#schemareshopinfo)|-|Information related to reshopping, if applicable.| | |
`reshopInfo`|[`ReshopInfo`](#schemareshopinfo)|-|Information related to reshopping, only available during modify (and not shopping) flow| |
No description provided.