[EDOI] Add new object types EDOI

[i506210]

No description provided.

[cla-assistant]

All committers have signed the CLA.

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[schneidermic0]

Hi @i506210,

Thank you for your contribution.

Would you mind to split this pull request (PR) into two PRs? One for EDOI and one for EDOT. I believe the handling for one PR per object type will be easier.

Furthermore, you might want to remove the .DS_Store files from the PR.

Thanks :)

[i506210]

Hi @i506210,

Thank you for your contribution.

Would you mind to split this pull request (PR) into two PRs? One for EDOI and one for EDOT. I believe the handling for one PR per object type will be easier.

Furthermore, you might want to remove the .DS_Store files from the PR.

Thanks :)

Hi @schneidermic0,

I have split Pull request into 2 and triggered PR. could you please check

Thanks & REgards,
Venkat

[Markus1812]

Hi Venkat,

thanks for the update. I've added some questions/comments to your pull request.

Please note, that for the title and description, we use title case and sentence case respectively. I've not marked every occurrence but if you could please adjust that.

"! <p class="shorttext">Interface Version</p>    "<- title (title case)
"! Interface version                             "<- description (sentence case)

[i506210]

Hi Venkat,

thanks for the update. I've added some questions/comments to your pull request.

Please note, that for the title and description, we use title case and sentence case respectively. I've not marked every occurrence but if you could please adjust that.

"! <p class="shorttext">Interface Version</p>    "<- title (title case)
"! Interface version                             "<- description (sentence case)

Hi

Hi Venkat,

thanks for the update. I've added some questions/comments to your pull request.

Please note, that for the title and description, we use title case and sentence case respectively. I've not marked every occurrence but if you could please adjust that.

"! <p class="shorttext">Interface Version</p>    "<- title (title case)
"! Interface version                             "<- description (sentence case)

Hi Michael,

I corrected all the places.

Thanks & Regards,
Venkat

[schneidermic0]

@GuilhermeSaraiva96 requested my review.

Please see my feedback and questions below.

[schneidermic0]

The example is missing. The example (and its example data) would be really helpful for our reviews. In the end it is needed anyhow.

If this won't be feasible we should create at least an issue in this repository for adding the example later.

[i506210]

Right now I haven't worked on preparing example

[schneidermic0]

OK, before we merge, we should create at least an issue for this in this repository. Pleas keep this comment as unresolved...

[schneidermic0]

I have reacted to your comments

[schneidermic0]

Thanks, @i506210 for all your adaptations.

Except the missing example this looks good to me, now. I add also the label for UX review, now.