chore: prevent translation changes being merged without the correct configurations #19964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RadhepS
changed the title
spartacus
|
||||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/cxspa-9258
|
| Run status |
|
| Run duration | 11m 56s |
| Commit |
|
| Committer | Radhep Sabapathipillai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Platonn
reviewed
Feb 13, 2025
ci-scripts/validate-translations.sh
Outdated
Comment on lines
55
to
56
| # Find all translation folders in the repository | ||
| translation_paths=$(find . -type d -path '*/assets/translations') |
There was a problem hiding this comment.
While running the script on local (where having /dist folder with already built libs), I've got a failure of the script:
Translations file not found: ./dist/organization/account-summary/assets/translations/translations.ts
Suggested change
| # Find all translation folders in the repository | |
| translation_paths=$(find . -type d -path '*/assets/translations') | |
| # Find all translation folders in the repository, excluding node_modules/ and dist/ | |
| translation_paths=$(find . -type d -path '*/assets/translations' -not -path './node_modules/*' -not -path './dist/*') | |
| `` |
Platonn
reviewed
Feb 13, 2025
Comment on lines
32
to
33
| changed_files=$(git diff --name-only $BASE_COMMIT $HEAD_COMMIT | grep 'assets/translations') | ||
|
|
There was a problem hiding this comment.
Here we account only for the pattern assets/translations, but it can be also assets/src/translations (with src in the middle).
When I removed an expected export statement or import statement in files in the folder projects/assets/src/translations/ - the script didn't complain, but it should.
We need take it into account:
- in line 32
- in line 37
- in file
ci-scripts/validate-translations.shin line 56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://jira.tools.sap/browse/CXSPA-9258