Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2e): enable access continuum as optional dependency #19984

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

sdrozdsap
Copy link
Contributor

@sdrozdsap sdrozdsap commented Feb 11, 2025

Closes: https://jira.tools.sap/browse/CXSPA-6523

Testing

Prerequisites
Enable continuum.example-e2e.cy.ts to run in CI by renaming it to continuum.e2e.cy.ts

Scenario 1
IF Env variable for CONTINUUM_REGISTRY_TOKEN exists THEN test should run. Currently it is failing so we expect a failing CI job
Result: CI Run
image
image

Scenario 2
IF Env variable for CONTINUUM_REGISTRY_TOKEN doesn't exist THEN test file should run, but all access-continuum related methods will be skipped. Therefore CI job should pass. We expect warning in the logs about missing CONTINUUM_REGISTRY_TOKEN
Result: CI Run
image
image

Scenario 3
IF Env variable for CONTINUUM_REGISTRY_TOKEN contains invalid value THEN test file should run, but all access-continuum related methods will be skipped. Therefore CI job should pass. We expect to not have warning in the logs about missing CONTINUUM_REGISTRY_TOKEN
Result: CI Run
image

Next steps

Figure out if there is a better way to indicate that continuum doesn't run the test. Currently there is a warning, but the test passes

@github-actions github-actions bot marked this pull request as draft February 11, 2025 17:01
@sdrozdsap sdrozdsap force-pushed the feat/reenable-access-continuum branch 3 times, most recently from fb05173 to afa4b95 Compare February 11, 2025 17:06
@sdrozdsap sdrozdsap marked this pull request as ready for review February 11, 2025 17:08
@sdrozdsap sdrozdsap force-pushed the feat/reenable-access-continuum branch from cc32129 to 65341d4 Compare February 11, 2025 17:08
@sdrozdsap sdrozdsap requested a review from Zeyber February 11, 2025 17:08
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft February 11, 2025 17:08
@sdrozdsap sdrozdsap marked this pull request as ready for review February 12, 2025 07:27
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@sdrozdsap sdrozdsap force-pushed the feat/reenable-access-continuum branch from 4148c63 to 8ef69c5 Compare February 12, 2025 12:33
@github-actions github-actions bot marked this pull request as draft February 12, 2025 12:33
@sdrozdsap sdrozdsap force-pushed the feat/reenable-access-continuum branch from 7440309 to 9a31731 Compare February 12, 2025 12:36
@sdrozdsap sdrozdsap marked this pull request as ready for review February 12, 2025 12:36
@github-actions github-actions bot marked this pull request as draft February 12, 2025 12:37
@sdrozdsap sdrozdsap marked this pull request as ready for review February 12, 2025 12:37
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

Copy link

cypress bot commented Feb 12, 2025

spartacus    Run #47017

Run Properties:  status check passed Passed #47017  •  git commit 830fbb714f ℹ️: Merge c2efddd722fa0f383adfdac107a196b858fe0630 into 8e47b2eb18f1508e20ffb6ffc356...
Project spartacus
Branch Review feat/reenable-access-continuum
Run status status check passed Passed #47017
Run duration 04m 40s
Commit git commit 830fbb714f ℹ️: Merge c2efddd722fa0f383adfdac107a196b858fe0630 into 8e47b2eb18f1508e20ffb6ffc356...
Committer sdrozdsap
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft February 13, 2025 08:11
Copy link

cypress bot commented Feb 13, 2025

spartacus    Run #47018

Run Properties:  status check passed Passed #47018  •  git commit 09bfd6343f: [TEST] Invalid CONTINUUM_ACCESS_TOKEN
Project spartacus
Branch Review feat/reenable-access-continuum
Run status status check passed Passed #47018
Run duration 12m 21s
Commit git commit 09bfd6343f: [TEST] Invalid CONTINUUM_ACCESS_TOKEN
Committer Sergiej Drozd
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 22
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 815
View all changes introduced in this branch ↗︎

@sdrozdsap sdrozdsap force-pushed the feat/reenable-access-continuum branch from a065f3e to 4cd6a54 Compare February 13, 2025 09:08
@sdrozdsap sdrozdsap marked this pull request as ready for review February 13, 2025 09:09
@sdrozdsap sdrozdsap force-pushed the feat/reenable-access-continuum branch from 4cd6a54 to 14929b2 Compare February 13, 2025 09:10
@sdrozdsap sdrozdsap requested a review from a team as a code owner February 13, 2025 09:10
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft February 13, 2025 09:11
@sdrozdsap sdrozdsap force-pushed the feat/reenable-access-continuum branch from 14929b2 to 5015158 Compare February 13, 2025 09:49
@sdrozdsap sdrozdsap marked this pull request as ready for review February 13, 2025 09:50
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft February 13, 2025 09:50
@sdrozdsap sdrozdsap marked this pull request as ready for review February 13, 2025 09:50
@github-actions github-actions bot marked this pull request as draft February 13, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant