-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2e): enable access continuum as optional dependency #19984
Draft
sdrozdsap
wants to merge
7
commits into
develop
Choose a base branch
from
feat/reenable-access-continuum
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb05173
to
afa4b95
Compare
cc32129
to
65341d4
Compare
Merge Checks Failed
|
Merge Checks Failed
|
4148c63
to
8ef69c5
Compare
7440309
to
9a31731
Compare
Merge Checks Failed
|
spartacus
|
Project |
spartacus
|
Branch Review |
feat/reenable-access-continuum
|
Run status |
|
Run duration | 04m 40s |
Commit |
|
Committer | sdrozdsap |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
3
|
|
2
|
|
0
|
|
125
|
View all changes introduced in this branch ↗︎ |
spartacus
|
Project |
spartacus
|
Branch Review |
feat/reenable-access-continuum
|
Run status |
|
Run duration | 12m 21s |
Commit |
|
Committer | Sergiej Drozd |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
1
|
|
22
|
|
0
|
|
815
|
View all changes introduced in this branch ↗︎ |
a065f3e
to
4cd6a54
Compare
4cd6a54
to
14929b2
Compare
Merge Checks Failed
|
14929b2
to
5015158
Compare
Merge Checks Failed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://jira.tools.sap/browse/CXSPA-6523
Testing
Prerequisites
Enable
continuum.example-e2e.cy.ts
to run in CI by renaming it tocontinuum.e2e.cy.ts
Scenario 1
![image](https://private-user-images.githubusercontent.com/163305268/412809367-e4bf64da-96e2-4a7c-97f9-a5adb0269b4d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzY4MjgsIm5iZiI6MTczOTU3NjUyOCwicGF0aCI6Ii8xNjMzMDUyNjgvNDEyODA5MzY3LWU0YmY2NGRhLTk2ZTItNGE3Yy05N2Y5LWE1YWRiMDI2OWI0ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQyMzQyMDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03MDFlZTU3ZTNkNWM1NThiNTU2OTA4NzhlMWZjN2RjNzM3OTgyM2JiZDhiNDkwODRlZGU2YjQ0YWNkYWFmOGE4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.8tXON1a7Qn1jM6SHLH77pZip73beMPk-9EZu4o5z_aY)
![image](https://private-user-images.githubusercontent.com/163305268/412836695-59736d38-735f-4b6f-95d9-8c1bb8772ea3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzY4MjgsIm5iZiI6MTczOTU3NjUyOCwicGF0aCI6Ii8xNjMzMDUyNjgvNDEyODM2Njk1LTU5NzM2ZDM4LTczNWYtNGI2Zi05NWQ5LThjMWJiODc3MmVhMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQyMzQyMDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yOWZlOTRhOTBlZGM4ODVmMmQxMzM2NTkyMmVmYTBjZDcxNjRlNDIyNjRlOWU2MTliYTQ2NmZjZTEzN2NmMTI0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.6AVn7M6I_GDgb-sHYwQ6D3WYEwvk76vwr_RzGG4KIik)
IF Env variable for
CONTINUUM_REGISTRY_TOKEN
exists THEN test should run. Currently it is failing so we expect a failing CI jobResult: CI Run
Scenario 2
![image](https://private-user-images.githubusercontent.com/163305268/412826013-dd1f4136-efc7-48b8-b135-e31143d1c2f1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzY4MjgsIm5iZiI6MTczOTU3NjUyOCwicGF0aCI6Ii8xNjMzMDUyNjgvNDEyODI2MDEzLWRkMWY0MTM2LWVmYzctNDhiOC1iMTM1LWUzMTE0M2QxYzJmMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQyMzQyMDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05NDZiN2Q0NGRiYmIyMjFkODdlNmNmMTJiYWNlOGQ4MDk0MzlmOTEwOTc0MzEzNDFhMzU0NDNmN2FlYjk1ZmZjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.xBgkNLcMB0ijB7nAKFXVNxxnS_3iJ4AZs7UJputgApE)
![image](https://private-user-images.githubusercontent.com/163305268/412826575-c99c7108-2d2e-4ca6-89df-439669f588da.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzY4MjgsIm5iZiI6MTczOTU3NjUyOCwicGF0aCI6Ii8xNjMzMDUyNjgvNDEyODI2NTc1LWM5OWM3MTA4LTJkMmUtNGNhNi04OWRmLTQzOTY2OWY1ODhkYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQyMzQyMDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZmRlOTNmNzFkMzk1ODZlN2JhYWZlYTc1YWFmNzg2OGE1ODkzMDMzNjQwY2MyOTY3N2U1MzRkZjgwOTYxOGQ5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.t8FHQAGRB-Mv2AmKwdbXVAZXpONr6Sr25zPZQQrIaeo)
IF Env variable for
CONTINUUM_REGISTRY_TOKEN
doesn't exist THEN test file should run, but all access-continuum related methods will be skipped. Therefore CI job should pass. We expect warning in the logs about missingCONTINUUM_REGISTRY_TOKEN
Result: CI Run
Scenario 3
![image](https://private-user-images.githubusercontent.com/163305268/412888723-ed32a36f-1e62-4309-958a-a53619dd727a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzY4MjgsIm5iZiI6MTczOTU3NjUyOCwicGF0aCI6Ii8xNjMzMDUyNjgvNDEyODg4NzIzLWVkMzJhMzZmLTFlNjItNDMwOS05NThhLWE1MzYxOWRkNzI3YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQyMzQyMDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hOWY5YjVlMDg2M2U1ZGFmNjMxYjdhZTFiYjUwZGUxZjAzNjQxZWYyMWU2MjViNzI1Y2JkOWU3NmQ5YTZiMzAyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.CG5ScJAZ-8ddfMO3FwKwJN8XJ1RhGXMIp4vchdXVFtU)
IF Env variable for
CONTINUUM_REGISTRY_TOKEN
contains invalid value THEN test file should run, but all access-continuum related methods will be skipped. Therefore CI job should pass. We expect to not have warning in the logs about missingCONTINUUM_REGISTRY_TOKEN
Result: CI Run
Next steps
Figure out if there is a better way to indicate that continuum doesn't run the test. Currently there is a warning, but the test passes