generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 7
feat(autofix): Fix deprecated Configuration APIs #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RandomByte
wants to merge
6
commits into
main
Choose a base branch
from
autofix-basic-configuration-apis-rebased
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
387c180
to
380a937
Compare
afe10d5
to
e719759
Compare
RandomByte
commented
Jun 17, 2025
mustNotUseReturnValue: true, | ||
})), | ||
...t.methods(["setRTL", "setLanguage"], callExpressionFix({ | ||
scope: FixScope.FirstChild, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fyi:
Yesterday I noticed the scope was wrong here. I corrected it in b08b237#diff-0b1c00da90d25004cd6d18142125bea5ced9fd4708ea7ac9a5d7519ac151960fR17
You'll probably see this in a conflict when rebasing this PR 👍
829e96a
to
3c2f75b
Compare
350b8f9
to
a010a78
Compare
b36d877
to
f1a0571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #683 and #685
JIRA: CPOUI5FOUNDATION-1038