Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Builder: generateFlexChangesBundle task is always enabled for applications #931

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

RandomByte
Copy link
Member

This task was enabled since at least v2 (probably since v0 already):
https://github.com/SAP/ui5-builder/blob/v2.11.11/lib/types/application/ApplicationBuilder.js#L46

Not sure why we missed it in this list. Also fix formatting in the
markdown

…for applications

This task was enabled since at least v2 (probably since v0 already):
https://github.com/SAP/ui5-builder/blob/v2.11.11/lib/types/application/ApplicationBuilder.js#L46

Not sure why we missed it in this list. Also fix formatting in the
markdown
@RandomByte RandomByte requested a review from a team February 26, 2024 13:26
Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about downporting this change also to v2 and v3 docu?

@RandomByte
Copy link
Member Author

What about downporting this change also to v2 and v3 docu?

Yeah, will do for v3. Maybe not v2 since it's out of maintenance.

@RandomByte RandomByte merged commit 68f8b72 into main Feb 26, 2024
7 checks passed
@RandomByte RandomByte deleted the builder-generateFlexChangesBundle-enabled branch February 26, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants