Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-multi-combobox/ui5-combobox): introduce open property #11044

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(ui5-multi-combobox/ui5-combobox): introduce open property #11044

wants to merge 3 commits into from

Conversation

StefanDimitrov04
Copy link
Contributor

FIXES: #7678

elenastoyanovaa
elenastoyanovaa requested changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you should add a close event in the Combo as well - see MCB for reference or other popup related components. How will the user know that the open property is set to false otherwise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenastoyanovaa elenastoyanovaa elenastoyanovaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: New property to ui5-combobox to make input clickable
2 participants
@StefanDimitrov04 @elenastoyanovaa