Skip to content

docs(ui5-ai-button): improve pattern based on design feedback #11835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

didip1000
Copy link
Contributor

@didip1000 didip1000 commented Jul 2, 2025

Reworded the dialog in the AI Regenerate pattern based on designer feedback.

Previously:

Do you wish to proceed?

Now:

Do you want to continue?

@didip1000
Copy link
Contributor Author

I think the confirmation button button should also be reworded from proceed to continue or ok but that needs more discussions with the designers.

@didip1000 didip1000 requested a review from Stoev July 2, 2025 13:57
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please fix the typo in the explanation - contine > continue.

Comment about considering rewording the button sounds reasonable as well.

@didip1000 didip1000 marked this pull request as ready for review July 7, 2025 08:39
@didip1000 didip1000 merged commit 73c5126 into main Jul 7, 2025
49 of 60 checks passed
@didip1000 didip1000 deleted the ai-sample-reword branch July 7, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants