Skip to content

Feature/caf pot #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 10, 2025
Merged

Feature/caf pot #703

merged 8 commits into from
Apr 10, 2025

Conversation

nathanielerowe
Copy link
Contributor

@nathanielerowe nathanielerowe commented Mar 27, 2025

Description

CAFMaker changes for POT Accounting. Add POT data label to options.

Relevant PR in sbncode: SBNSoftware/sbncode#495

@nathanielerowe nathanielerowe added the caf Common analysis framework label Mar 27, 2025
@nathanielerowe nathanielerowe self-assigned this Mar 27, 2025
@bear-is-asleep
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01

@bear-is-asleep bear-is-asleep moved this from Todo to To be Merged (RM only) in SBND March 2025 production Mar 27, 2025
@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_p01

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_p01

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

@jzennamo or @PetrilloAtWork can one of you review this PR? It passes the CI so it's otherwise ready to go.

@jzennamo jzennamo requested a review from JosiePaton April 1, 2025 18:33
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok!

@bear-is-asleep
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_p01 SBNSoftware/sbnanaobj@bug/coackley_caf_Mar25 SBNSoftware/sbnobj@v10_00_07

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

Approved

@bear-is-asleep bear-is-asleep moved this from To be Merged (RM only) to Approved (RM only) in SBND March 2025 production Apr 3, 2025
@bear-is-asleep bear-is-asleep merged commit 4c4f486 into develop Apr 10, 2025
3 of 4 checks passed
@bear-is-asleep bear-is-asleep moved this from Approved (RM only) to In tagged release in SBND March 2025 production Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caf Common analysis framework
Projects
Status: In tagged release
Development

Successfully merging this pull request may close these issues.

6 participants