refactor: define schemas as classes #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiadams
reviewed
Mar 25, 2025
.github/workflows/tests.yml
Outdated
| @@ -28,7 +28,20 @@ jobs: | |||
| - name: Install dependencies | |||
| run: poetry install | |||
|
|
|||
| - name: Pull Ollama Docker image | |||
| cls.embedding_model = MPNetAdapter() | ||
| cls.target_vector = "sentence_transformers_all_mpnet_base_v2" | ||
| cls.target_vector = "nomic_embed_text" |
There was a problem hiding this comment.
External components should be mocked
There was a problem hiding this comment.
This is for Weaviate vectorizer and should passed into the configuration of collections before the creation of them. Thus, I need a valid model to properly initialize it. The target_vector here only refers to the name of the named vector. Weaviate does not give us any testing client unfortunately. I understand your point and I will apply it for the OllamaAdapater.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #90