20240719 improve delete api

[jask1m]

when the /delete endpoint was called, the url is deleted, but then trying to delete the associated data (qrcode) returns an error, which in turn confuses the frontend and disrupted the ui from being re-rendered. rewrote the api to handle errors such that it won't raise exceptions, but logs whatever failed. - might need to look into how to handle deletion of associated data later if it keeps occurring.

[evanugarte]

lets do the logic like this, logger.exception will include the error automatically

    try:
        with MetricsHandler.query_time.labels("delete").time():
            if sqlite_helpers.delete_url(DATABASE_FILE, alias):
                try: # URL deleted, now attempt the associated data
                    qr_code_cache.delete(alias)
                    cache.delete(alias)
                except Exception:
                    logging.exception(f"Error deleting alias {alias} from cache") # log failure without raising exception

                return {"message": "URL deleted successfully"}
            raise HTTPException(status_code=HttpResponse.NOT_FOUND.code)
    except Exception:
        logging.exception(f"Unexpected error in delete_url for {alias}")
        raise HTTPException(status_code=HttpResponse.INTERNAL_SERVER_ERROR.code)

[evanugarte]

delete this

[evanugarte]

we can do the nested try for now, and watch the logs to see what happens