Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Dn/rotated linear to ac/reconstruction #67

Merged
merged 17 commits into from
Nov 12, 2024

Conversation

dhyan1272
Copy link

Linear Reconstruction, Rotated Coordinates, Quantitative Push Test, bug in Spherical Interpolation fix

Copy link

@Angelyr Angelyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented a few changes

Copy link

@onkarsahni onkarsahni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes needed. In this review, I only checked changes in src/pmpo_MPMesh_assembly.hpp and src/pmpo_utils.hpp.

Copy link

@onkarsahni onkarsahni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes needed.

Copy link

@onkarsahni onkarsahni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@onkarsahni
Copy link

Merged and deleted branch.

@onkarsahni onkarsahni merged commit c52003e into ac/reconstruction-code Nov 12, 2024
1 check passed
@onkarsahni onkarsahni deleted the dn/rotated_linear branch November 12, 2024 16:20
@onkarsahni onkarsahni mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants