Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old fastf1 deprecate Warn #202

Merged
merged 6 commits into from
Nov 12, 2023
Merged

Conversation

pbulsink
Copy link
Collaborator

This sets up deprecate warns for fastf1 < 3. We may wish to deprecate everything below v3.1 if we implement some of the multi-lap/multi-driver capabilities with ff1.session.pick_laps(), thoughts @SCasanova?

@pbulsink pbulsink requested a review from SCasanova November 10, 2023 02:18
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #202 (46b822f) into master (29ada65) will increase coverage by 0.19%.
The diff coverage is 100.00%.

❗ Current head 46b822f differs from pull request most recent head 54d8a0c. Consider uploading reports for the commit 54d8a0c to get more accurate results

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   90.00%   90.19%   +0.19%     
==========================================
  Files          18       18              
  Lines         620      622       +2     
==========================================
+ Hits          558      561       +3     
+ Misses         62       61       -1     
Files Coverage Δ
R/clear_f1_cache.R 88.37% <100.00%> (ø)
R/load_driver_telemetry.R 69.23% <100.00%> (ø)
R/load_race_session.R 91.17% <100.00%> (ø)
R/load_session_laps.R 95.83% <100.00%> (ø)
R/utils.R 79.66% <100.00%> (+2.46%) ⬆️

@pbulsink pbulsink marked this pull request as ready for review November 10, 2023 03:02
@SCasanova
Copy link
Owner

I think for functionality and uniformity, that's a good idea

@pbulsink
Copy link
Collaborator Author

Ok great. Ive thought of a better way of implementing this so I'll work on that this weekend.

@pbulsink pbulsink merged commit a04771f into SCasanova:master Nov 12, 2023
14 checks passed
@pbulsink pbulsink deleted the old_ff1_deprecate_warn branch November 13, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants