Cut off strings too long to show in ugfx.List #221
Conversation
|
Oh, by the way, the MIN() macro does double evaluation of its arguments, but that's not a problem here. I'm not too fond of it though, which is why I'm mentioning it. |
| @@ -635,7 +635,13 @@ void BWgwinListDefaultDraw(GWidgetObject* gw, void* param) { | |||
| } | |||
| } | |||
| #endif | |||
| gdispGFillStringBox(gw->g.display, gw->g.x+x+LST_HORIZ_PAD, gw->g.y+y, iwidth-LST_HORIZ_PAD, iheight, qi2li->text, gw->g.font, text, fill, justifyLeft); | |||
There was a problem hiding this comment.
why not justifyLeft | justifyTop ? That seems to work.
There was a problem hiding this comment.
It does?!
I just read the API docs and they say that text is always vertically centered and justify only adjusts horizontal. So either you're getting unintended correctness or the docs need to be updated :-).
There was a problem hiding this comment.
justifyTop is not mentioned either.
There was a problem hiding this comment.
I read the header file and found this constant. Tried it and it seemed to work. Haven't done further testing. :)
|
I've added my alternative pull-request here: #222 |
This relates to pull request #216. @basvs wrote:
This patch does exactly that. Since this patch is already very useful on its own, I created a new pull request for it.
I'm not too sure about the #ifdef GDISP_NEED_CLIP, though it will compile without it defined, it will render very wrongly. Maybe compilation should fail, perhaps with an error pragma?