-
-
Notifications
You must be signed in to change notification settings - Fork 1
Fix shaded scoreboard library integration with correct API exposure #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
twisti-dev
wants to merge
6
commits into
version/1.21
Choose a base branch
from
fix/scoreboard-library
base: version/1.21
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- .idea/vcs.xml: Language not supported
- gradle.properties: Language not supported
- surf-api-bukkit/surf-api-bukkit-server/build.gradle.kts: Language not supported
ammodev
reviewed
May 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats requested
Obviously a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of Changes
Resolved an issue where the scoreboard library was incorrectly loaded through the libs loader while its implementation was shaded. The patch ensures proper API exposure and runtime behavior by adjusting the dependency declarations and build configuration.
Details
IDE Configuration Update
CommitFormat
,CommitNamingConvention
) in.idea/vcs.xml
to enforce consistent commit message formats.Version Bump
gradle.properties
from1.21.4-2.13.3-SNAPSHOT
to1.21.4-2.13.4-SNAPSHOT
to reflect the patch.Dependency Scope Fix
runtimeOnly
toapi
forlibs.scoreboard.library.implementation
,libs.scoreboard.library.modern
, andlibs.scoreboard.library.api
insurf-api-bukkit-server/build.gradle.kts
to correctly expose the shaded scoreboard library during compilation and runtime.Motivation
The scoreboard library was improperly configured, causing it to be loaded at runtime but not properly exposed as an API due to shading. This fix aligns the dependency scope to ensure consistent functionality and developer access.
Impact
Testing
Additional Notes
Download Build‑JARs for this PR: pr-built-jars.zip