Update tooling and instructions for ER and RDD #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palemieux
requested changes
Mar 5, 2025
|
Can you create a sample RDD document under |
palemieux
requested changes
Mar 14, 2025
doc/main.html
Outdated
| <p>The <code>id</code> attribute shall be present on the <code>dl</code> element and equal to | ||
| <code>rdd-proponent</code>. | ||
|
|
||
| <p>If present, the <code>dl</code> element, as described in <a href="#sec-dl-element"></a>, shall use a single <code>dt</code> element for each company name designated as a Proponent of the document, and multiple lines of <code>dd</code> as needed for contact information for each company listed. The contact infomation should at least include an address and email, reach out to SMPTE HO for further deatails. </p> |
There was a problem hiding this comment.
Isn't a single
There was a problem hiding this comment.
... in fact, I am not convinced <dl> is the right approach if there are multiple proponents... can you provide an example of how this would work?
There was a problem hiding this comment.
<dl id="element-proponent">
<dt>Company name</dt>
<dd>Contact name</dd>
<dd>Contact email</dd>
<dd>Company Address</dd>
<dd>Company website</dd>
<dt>Company 2 name</dt>
<dd>Contact name</dd>
<dd>Contact email</dd>
<dd>Company 2 Address</dd>
<dd>Company 2 website</dd>
</dl>
Nothing prevents the usage of multiple dd for each dt, such as https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dl#single_term_multiple_descriptions. This is frankly the least ugly way to present, besides trying to to the same with ul and then wrapping a style in CSS.
There was a problem hiding this comment.
I added the above example to the documentation as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated instructions, updated Foreword (and streamlined logic), added clause for contact info, updated validation.