Feature: added sasl scram 256 and 512 functionality #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 20, 2020 00:43
0807Jpatel
changed the title
|
@hyperlink Could you please review this. |
ankyjk
reviewed
Mar 22, 2020
lib/kafkaClient.js
Outdated
| const request = protocol.encodeSaslAuthenticateRequest(this.clientId, correlationId, apiVersion, auth); | ||
| let request = null; | ||
| let decode = null; | ||
| let decodeArgs = null; |
There was a problem hiding this comment.
Can we write this way let request, decode, decodeArgs =null;
|
Are there any plans to merge this PR to master, so we can have SASL/SCRAM support in the kafka-node module? |
|
Can we get this merged? |
|
An error message is displayed when you connect to the ConsumerGroup using RAM-SHA-512. Authentication failed during authentication due to invalid credentials with SASL mechanism SCRAM-SHA-512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added scram-sha-256 and scram-sha-512 protocol support for kafka 0.11+.