#13140 Restore User Synchronization Button and Ensure Proper Keycloak… #13146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Synchronization Configuration
|
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13146 |
sergiupacurariu
requested changes
Sep 9, 2024
| @@ -1521,6 +1521,8 @@ messageCustomizableEnumValueSaved = Customizable enum value saved | |||
| messageExternalEmailAttachmentPassword=Please use this password to open the documents sent to you via email from SORMAS: %s | |||
| messageExternalEmailAttachmentNotAvailableInfo=Attaching documents is disabled because encryption would not be possible. To encrypt documents, the person needs to have either a national health ID specified, or a primary mobile phone number set with SMS sending set up on this system. | |||
| messagePersonNationalHealthIdInvalid=The entered national health ID does not seem to be correct | |||
| messageSyncUsersFromAuthProviderConfigurationError=Syncing users from authentication provider is not possible because the configuration is incorrect. Please contact an admin and inform them about this issue. | |||
There was a problem hiding this comment.
shouldn't we have a more specific message here since only "admin" users have access to this feature ?
We could point them out directly to the issue.
|
I would add description for "AUTH_PROVIDER_TO_SORMAS_USER_SYNC" feature configuration to the wiki page that contains feature configuration options: |
sergiupacurariu
approved these changes
Sep 9, 2024
sergiupacurariu
deleted the
13140_always-show-user-sync-button-with-keycloak-auth
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Synchronization Configuration
Fixes #13140