#4201 Errors repeatedly logged for minor configuration issues #7067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we really want to reduce the log level here? I think it makes the debugging process for the sysadmin harder. IMHO it makes more sense to fix the deployment than hiding errors that are legit. |
|
Alternatively we could just check for empty values and then skip the parsing |
vidi42
suggested changes
Nov 5, 2021
There was a problem hiding this comment.
I think we should better check and only parse the property values if they are not empty and if they are empty we could add a debug log mentioning this.
For the catch we should still log an error because some values might be set incorrectly and those should be pointed out.
…tor property parser methods
…nto 4201_missing-config-debug-log
vidi42
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4201
Changed logs to debug as suggested in the ticket