feat: imageInputForm 분리, drag&drop구현 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
image input form을 분리했슴다
드래그엔드롭 구현
이미지 삭제시 나머지 파일들에 대해 다시 reader로 읽어왔음 fileList에 의존하는 useEffect제거해서불필요한 re reading 방지
이미지 미리보기랑 실제 파일순서랑 맞춤
esthel7
approved these changes
Jul 18, 2024
app/writepost/page.tsx
Outdated
Comment on lines
139
to
143
| <ImageInputForm | ||
| fileList={files} | ||
| setFileList={setFiles} | ||
| className="flex flex-col gap-3" | ||
| ></ImageInputForm> |
There was a problem hiding this comment.
호오 간단쓰~ 여기 <ImageInputForm {...} /> 이렇게 바꿔주면 센스쟁이~🍀
Comment on lines
+58
to
+61
| newFileList.splice(index, 1); | ||
| newPreview.splice(index, 1); | ||
| setFileList(newFileList); | ||
| setPreview(newPreview); |
Comment on lines
+32
to
+46
| files.forEach((file, index) => { | ||
| const reader = new FileReader(); | ||
| reader.readAsDataURL(file); | ||
| reader.onloadend = () => { | ||
| previews[preview.length + index] = { | ||
| src: reader.result as string, | ||
| alt: file.name, | ||
| }; | ||
| cnt++; | ||
| if (cnt === files.length) { | ||
| setPreview(previews); | ||
| setIsLoading(false); | ||
| } | ||
| }; | ||
| }); |
There was a problem hiding this comment.
요렇게 하면 동일 파일도 들가는건가용?? 아 근데 delete를 index로 해서 삭제도 에러 없겟다 굿굿👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Photo
default.mov
오늘은 영상으로다가 드래그앤드롭이랑 순서 제대로 올라가는거 확인하면 됩니두
Issue number and link