Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a profiling page #91

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Adding a profiling page #91

merged 1 commit into from
Mar 7, 2025

Conversation

aplopez
Copy link
Contributor

@aplopez aplopez commented Feb 18, 2025

Adding a page describing how to profile any of the SSSD daemons.

The page be seen here: https://sssdio--91.org.readthedocs.build/contrib/profiling-sssd.html

Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the few comments, it looks good.

@aplopez
Copy link
Contributor Author

aplopez commented Feb 28, 2025

Fixed the comments and also some small errors I found.

@aplopez aplopez requested a review from danlavu March 4, 2025 09:25
danlavu
danlavu previously approved these changes Mar 4, 2025
Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, about the SELinux language, if someone needs help with it, there is always a web search, so it's not important. Thank you Alejandro

@aplopez
Copy link
Contributor Author

aplopez commented Mar 6, 2025

@danlavu It seems the configuration of this repository requires that you approve again this PR because I applied some changes. Sorry for this.

@alexey-tikhonov alexey-tikhonov added Accepted Pull request is accepted and removed Waiting for review Pull request is awaiting review labels Mar 7, 2025
@alexey-tikhonov alexey-tikhonov merged commit 5695dfd into SSSD:master Mar 7, 2025
2 checks passed
@alexey-tikhonov alexey-tikhonov added Pushed Pull request was merged and removed Accepted Pull request is accepted labels Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pushed Pull request was merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants