Various portability fixes

[fossdd]

See commit messages for further information

[sumit-bose]

Hi,

thank you for the fixes, I'm fine with them. Just a comment about the commit messages, afaik "quirk" is written with a "k".

bye,
Sumit

[fossdd]

fixed, thanks!

[alexey-tikhonov]

What does musl use instead?

[fossdd]

I'm not sure that there is a equivalent to glibc's NETDB_INTERNAL.

See glibc's implementation (https://github.com/bminor/glibc/blob/596130591ae4b058a529cc1318b95e624559054c/resolv/netdb.h#L63-L75) and musl's (https://github.com/bminor/musl/blob/c47ad25ea3b484e10326f933e927c0bc8cded3da/include/netdb.h#L123-L129). Also POSIX seems not to offfer a equivalent: https://pubs.opengroup.org/onlinepubs/009696799/functions/gethostbyaddr.html

[alexey-tikhonov]

But how will musl work with 'libnss_sss' if it doesn't expect -1 to be returned?

[fossdd]

Hmm, do you know where libnss_sss returns NETDB_INTERNAL to musl?

[alexey-tikhonov]

$ grep -rn NETDB_INTERNAL *
nss_hosts.c:233:        *h_errnop = NETDB_INTERNAL;
nss_hosts.c:240:        *h_errnop = NETDB_INTERNAL;
nss_hosts.c:247:        *h_errnop = NETDB_INTERNAL;
nss_hosts.c:282:        *h_errnop = NETDB_INTERNAL;
nss_hosts.c:294:        *h_errnop = NETDB_INTERNAL;
nss_hosts.c:353:        *h_errnop = NETDB_INTERNAL;
nss_hosts.c:360:        *h_errnop = NETDB_INTERNAL;
nss_hosts.c:367:        *h_errnop = NETDB_INTERNAL;
nss_hosts.c:412:        *h_errnop = NETDB_INTERNAL;
nss_hosts.c:424:        *h_errnop = NETDB_INTERNAL;
nss_hosts.c:461:        *h_errnop = NETDB_INTERNAL;
nss_hosts.c:479:            *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:204:        *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:211:        *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:223:        *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:246:        *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:266:        *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:311:        *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:318:        *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:327:        *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:349:        *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:372:        *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:392:        *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:421:        *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:444:            *h_errnop = NETDB_INTERNAL;
nss_ipnetworks.c:467:        *h_errnop = NETDB_INTERNAL;

[alexey-tikhonov]

Not sure why above patch was so contained.

[alexey-tikhonov]

@fossdd, what is your stance on this?
Do you want to dig deeper or are you fine to merely get code to the state "it compiled with musl"?

@sumit-bose, do you think we could extend 1a1e914 to replace all uses of NETDB_INTERNAL with NO_RECOVERY / HOST_NOT_FOUND (portable)?

@scabrero, do you remember if there was a reason to use NETDB_INTERNAL specifically?

[fossdd]

For me, it's fine. we already ship this code downstream, and afaik this snippet worked fine.

[scabrero]

@scabrero, do you remember if there was a reason to use NETDB_INTERNAL specifically?

I don't remember if there was a specific reason by that time, but having a look it is probably because it is the way to say "check errno":
# define NETDB_INTERNAL -1 /* See errno. */

[alexey-tikhonov]

For me, it's fine. we already ship this code downstream, and afaik this snippet worked fine.

Ok, if nobody else chimes in in a next day or two, this will be merged "as is".

[alexey-tikhonov]

Pushed PR: #7861

• master
  • 459cc6b - CLIENT: Define NETDB_INTERNAL if not already
  • 8886a27 - failover: Clarify message for local hosts file resolution failure
  • 8edb14f - MC: Use useconds_t instead of their reserved type