tests: Update mock date to postpone timezone related failures #7884
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please replace "BUG:" with "Resolves:" in the commit message. |
Because timezones can change throughout the years, mktime calculates timestamp according to a timezone valid at that date, but tzset uses current timezone and that can lead to an incorrect result. Resolves: SSSD#7209
alexey-tikhonov
approved these changes
Mar 18, 2025
ACK |
thalman
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because timezones can change throughout the years, mktime calculates timestamp according to a timezone valid at that date, but tzset uses current timezone and that can lead to an incorrect result.
I've decided on a more recent date to cover timezone changes that happened in other countries (see tzdata-meta for a list of changes).
As soon as there appears a better and tested solution to fix/rewrite
sss_utc_to_time_tto properly work with timezones, this date will not need constant updates.See #7209 for more information.