11.6.1

* 11.6.1

* Update lock file.

* SHS-5911: Add indicator of 3rd level shortcut menu (#1681)

* SHS-5911: Add indicator of 3rd level shortcut menu.

* fix(shs-5912): change layout of ckeditor styles dropdown list (#1688)

Co-authored-by: joegl <[email protected]>

* SHS:5892: Site managers can perform actions on user accounts that don't make sense with SSO (#1682)

* feat(shs-5892): remove actions from people view

* feat(shs-5892): remove elements from used edit form

* fix(shs-5892): fix issues in user edit form alter

* fix(shs-5892): remove delete actions only for non admin users

* Updated dependencies

* fix(shs-5911): use absolute path for image url to prevent error when drupal aggregates image (#1693)

* HSD8-1700: Increase Tugboat Max Allowed Packet size to 512MB. (#1695)

Co-authored-by: Seth Hendrick <[email protected]>

* SHS-5808: Uninstall Webform module (#1625)

* SHS-5905: Rework social media footer (#1662)

* feat(SHS-5905): Recreate social media block as a custom block plugin

* feat(SHS-5905): Add composer.lock

* feat(SHS-5905): Enable multivalue form element module

* feat(SHS-5905): Add update hook for permissions change

* fix(SHS-5905): Fix error for default config and add cache context for user

* fix(SHS-5905): Contextual menu still not rendering on Tugboat for non-admins

* fix(SHS-5905): Fix attached library for contextual menu

* fix(SHS-5909): Strict checking of the array seemed to fix the contextual links on local

* fix(SHS-5905): Remove strict checking

* fix(SHS-5905): Remove old permissions before adding social media block permissions

* fix(SHS-5905): Linting fixes

* chore(SHS-5905): WIP TEST ONLY - see if removing the code block in the profile works on tugboat

* fix(SHS-5905): Fix contextual menu for non-admins

* feat(SHS-5905): Remove permission update hook and add dependency on one in profile

* feat(shs-5906): icon logic, templates and styles for social media footer block (#1673)

* chore(SHS-5905): Temp remove code to test other contextual menus

* feat(SHS-5905): Add custom contextual link

* fix(SHS-5905): Get contextual links working (finally) for Social Media block

* fix(shs-5905): fixes in social media block

* fix(shs-5905): replace multivalue_form_element with custom version in social media block

* fix(shs-5905): remove multivalue_form_element module

* fix(shs-5905): update social media block links help text

* fix(shs-5905): social media footer block fixes

---------

Co-authored-by: Andrés Díaz Soto <[email protected]>

* Update hook to delete webform submissions

* SHS-5958: Bug: Inconsistent "Add Above" feature (#1692)

* fix(SHS-5958): Fix issue with paragraphs features to allow add buttons on non gin/claro themes

* feat(SHS-5958): Add config and update hook to allow add paragraphs in between

* refactor(SHS-5958): Change how we are updating the add in between to config

* test(SHS-5958): Update test to refelect new buttons

* test(SHS-5958): Update testPostCard test for new add in between buttons

* test(SHS-5958): Update other tests for new add in between buttons

* test(SHS-5958): Add a wait in test to make sure JS add in between buttons load

* test(SHS-5958): Fix photo album test - photo album can come before or after text component, making tests work sometimes but not all the time

* fix(shs-5958): fix video embed test

* fix(shs-5958): fix private page tests

* fix(shs-5958): fix video embed test

* fix(shs-5958): fix private page tests

* fix(shs-5958): fixes in tests

* fix(shs-5958): fix private page tests

* fix(shs-5958): fix private page tests

* chore(SHS-5958): Remove unnecessary layout builder config

* chore(SHS-5958): Revert hidden layout builder layout

* chore(SHS-5958): Revert composer.lock to 11.6.1 version

---------

Co-authored-by: Andrés Díaz Soto <[email protected]>

* Removed unintended underscore in update hook name

* fixup update function name

* HSD8-1707: Removed edit button from default people view to resolve button display to anonymous users. (#1701)

* SHS-5904: Add new "log out" block to existing sites (#1696)

* HSD8-1664: Updated PR template (#1685)

* Updated PR template.

* Updated sanitiztion line.

* dropped ready for review title. added review tasks heading.

---------

Co-authored-by: joegl <[email protected]>

* Revoke any webform permissions before uninstall module

* Removed assert_options from settings files

* HSD8-1702: delete mediterraneanstudies

---------

Co-authored-by: Github Actions <[email protected]>
Co-authored-by: joegl <[email protected]>
Co-authored-by: Mariana Núñez <[email protected]>
Co-authored-by: Andrés Díaz Soto <[email protected]>
Co-authored-by: Mike Decker <[email protected]>
Co-authored-by: Seth <[email protected]>
Co-authored-by: Seth Hendrick <[email protected]>
Co-authored-by: Marc Berger <[email protected]>
Co-authored-by: Joe Gilliland-Lloyd <[email protected]>

.github/pull_request_template.md

@@ -1,10 +1,8 @@
-# READY FOR REVIEW
-
-## Summary
-_[briefly summarize the changes here]_
+# Summary
+_[briefly summarize the changes here. TL;DR - what's this PR for?]_
 
 ## Need Review By (Date)
-_['10/30', 'asap', etc.]_
+_[When does this need to be reviewed by? '10/30', 'asap', etc.]_
 
 ## Urgency
 _['low', 'medium', 'high', etc.]_
@@ -13,6 +11,22 @@ _['low', 'medium', 'high', etc.]_
 1. _[First testing step]_
 2. ...
 
-## PR Checklist
-- [PR Checklist](https://gist.github.com/sherakama/0ba17601381e3adbe0cad566ad4d80a5)
-- [Humsci Basic PR Checklist](https://github.com/SU-HSDO/suhumsci/blob/develop/docs/HumsciBasicPRChecklist.md)
+# Review Tasks
+
+## Backend / Functional Validation
+### Code
+- [ ] Are the naming conventions following our standards?
+- [ ] Are PHP functions and variables in `snake_case` and not `camelCase`?
+- [ ] Does Drupal code follow [Drupal Coding Standards](https://www.drupal.org/docs/develop/standards/php/php-coding-standards)?
+- [ ] Does the code have sufficient inline comments?
+- [ ] Is there anything in this code that would be hidden or hard to discover through the UI?
+- [ ] Are there any [code smells](https://blog.codinghorror.com/code-smells/)?
+- [ ] Are tests provided?
+
+### Code security
+- [ ] Is all [user input properly sanitized when rendered](https://www.drupal.org/docs/8/security/drupal-8-sanitizing-output)?
+- [ ] Any obvious [security flaws or new areas for attack](https://www.drupal.org/docs/8/security)?
+
+### General
+- [ ] Is there anything included in this PR that is not related to the problem it is trying to solve?
+- [ ] Is the approach to the problem appropriate?

.tugboat/config.yml

@@ -44,7 +44,7 @@ services:
       update:
         - rm -rf vendor
         - composer install --no-ansi
-        - mysql -h mysql -P 3306 -u tugboat -ptugboat -e 'SET GLOBAL max_allowed_packet=67108864;'
+        - mysql -h mysql -P 3306 -u tugboat -ptugboat -e 'SET GLOBAL max_allowed_packet=536870912;'
         # Sync to hs_colorful, hs_colorful database & files and create user.
         - blt drupal:sync:files --site=hs_colorful
         - drush @hs_colorful.local user:create tugboat --password=pushcar || true
@@ -66,7 +66,7 @@ services:
       build:
         - rm -rf vendor
         - composer install --no-ansi
-        - mysql -h mysql -P 3306 -u tugboat -ptugboat -e 'SET GLOBAL max_allowed_packet=67108864;'
+        - mysql -h mysql -P 3306 -u tugboat -ptugboat -e 'SET GLOBAL max_allowed_packet=536870912;'
 
         - drush @hs_colorful.local cr
         - drush @hs_colorful.local eval '\Drupal::moduleHandler()->loadInclude("user", "install");user_update_10000();'
@@ -105,7 +105,7 @@ services:
     image: tugboatqa/mysql:5
     commands:
       update:
-        - mysql -e 'SET GLOBAL max_allowed_packet=67108864;'
+        - mysql -e 'SET GLOBAL max_allowed_packet=536870912;'
         # Delete and recreate the database for each site.
         - mysql -e "DROP DATABASE IF EXISTS hs_colorful; CREATE DATABASE hs_colorful;"
         - mysql -e "DROP DATABASE IF EXISTS hs_traditional; CREATE DATABASE hs_traditional;"

blt/blt.yml

@@ -124,7 +124,6 @@ multisites:
   - lowe
   - mathematics
   - mcs
-  - mediterraneanstudies
   - memorylab
   - middleeast
   - morrisoninstitute

composer.json

@@ -282,6 +282,9 @@
                 "https://www.drupal.org/project/paragraphs_browser/issues/3381981": "https://www.drupal.org/files/issues/2023-08-22/3381981-sort-by-weight-4.patch",
                 "https://www.drupal.org/project/paragraphs_browser/issues/3064852": "https://www.drupal.org/files/issues/2023-11-07/3064852-allow-hiding-browser-12.patch"
             },
+            "drupal/paragraphs_features": {
+                "Add-in only works if active theme is claro or gin https://www.drupal.org/project/paragraphs_features/issues/3353704": "https://www.drupal.org/files/issues/2024-03-22/3353704-mr12-18.patch"
+            },
             "drupal/redirect": {
                 "https://www.drupal.org/project/redirect/issues/3057250": "https://www.drupal.org/files/issues/2024-08-11/redirect--2024-08-11--3057250-79.patch",
                 "https://www.drupal.org/project/redirect/issues/3018897": "https://www.drupal.org/files/issues/2024-08-12/redirect-3018897-28.patch"