Skip to content

Commit

Permalink
SHS 5130 Use <hr> when there is no color band text (#1398)
Browse files Browse the repository at this point in the history
* fix(shs-5130): adding hr tag when there is no color band text

* fix(SHS-5130): hr adjustments

* fix(SHS-5130): hr margins and another instance
  • Loading branch information
mndonx authored Nov 21, 2023
1 parent c07e943 commit 4eb18bb
Show file tree
Hide file tree
Showing 9 changed files with 24 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,9 @@
{% endif %}

<div{{ attributes }}>
<h2 class="hb-color-band--text">{{ color_band_text }}</h2>
{% if color_band_text %}
<h2 class="hb-color-band--text">{{ color_band_text }}</h2>
{% else %}
<hr class="hb-color-band--text" />
{% endif %}
</div>

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docroot/themes/humsci/humsci_airy/css/humsci_airy.css

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,11 @@
padding: hb-calculate-rems(20px);
}
}

hr {
margin-block-start: 0.83em;
margin-block-end: 0.83em;
border: 0;
font-size: 3.6rem;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,14 @@
{%- set attributes = attributes.addClass(classes) -%}

{% if variant %}
{% set variant_class = "hb-color-band--#{variant}" %}
{% set variant_class = "hb-color-band--#{variant}" %}
{% set attributes = attributes.addClass(variant_class) %}
{% endif %}

<div{{ attributes }}>
<h2 class="hb-color-band--text">{{ color_band_text }}</h2>
{% if color_band_text %}
<h2 class="hb-color-band--text">{{ color_band_text }}</h2>
{% else %}
<hr class="hb-color-band--text" />
{% endif %}
</div>

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

0 comments on commit 4eb18bb

Please sign in to comment.