Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5114: Fix warbler hs-button color #1395

Merged
merged 2 commits into from
Nov 9, 2023
Merged

SHS-5114: Fix warbler hs-button color #1395

merged 2 commits into from
Nov 9, 2023

Conversation

cienvaras
Copy link
Collaborator

READY FOR REVIEW

Summary

  • Update link styles to prevent hs-button color to be overridden in warbler

Need Review By (Date)

11/9

Urgency

medium

Steps to Test

  1. Install islamicstudies site
  2. Go to the Past Event Recordings view config page. Go "Fields > Content: Event Video > Style Settings" and change the "CSS Class" from hs-secondary-button to hs-button. Save the view
  3. Visit the Past Event Recordings page and confirm that the "Watch the Video" buttons text is white.
Screenshot 2023-11-08 at 22 24 30

PR Checklist

@cienvaras cienvaras requested a review from mndonx November 9, 2023 04:25
@cienvaras cienvaras self-assigned this Nov 9, 2023
@cienvaras cienvaras marked this pull request as ready for review November 9, 2023 04:26
mndonx
mndonx approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@mndonx mndonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and it works as expected. My condolences for the excessive CSS that has to be used to create Warbler overrides!

@cienvaras cienvaras merged commit d7275e7 into fk-stnfd-sprint-38 Nov 9, 2023
1 check passed
@cienvaras cienvaras deleted the shs-5114-fix-warbler-button-color branch November 9, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mndonx mndonx mndonx approved these changes

Assignees

@cienvaras cienvaras

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cienvaras @mndonx