Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5116: Move editoria11y button #1396

Merged
merged 2 commits into from
Nov 9, 2023
Merged

SHS-5116: Move editoria11y button #1396

merged 2 commits into from
Nov 9, 2023

Conversation

cienvaras
Copy link
Collaborator

READY FOR REVIEW

Summary

Change position of editoria11y component

Need Review By (Date)

11/9

Urgency

medium

Steps to Test

  1. Log in as a "Developer" (admin) user
  2. Confirm that the editoria11y component is rendered on top of the "Back to Top" button on the right bottom corner of the page and that both are clickable at the same time
Screenshot 2023-11-09 at 08 32 58

PR Checklist

@cienvaras cienvaras requested a review from mndonx November 9, 2023 14:33
@cienvaras cienvaras self-assigned this Nov 9, 2023
mndonx
mndonx approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@mndonx mndonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and it works as expected!

@cienvaras cienvaras merged commit 36e8cb7 into fk-stnfd-sprint-38 Nov 9, 2023
1 check passed
@cienvaras cienvaras deleted the shs-5116-move-editoria11y-button branch November 9, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mndonx mndonx mndonx approved these changes

Assignees

@cienvaras cienvaras

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cienvaras @mndonx