Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS 5095 Theming User Login Page #1399

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Conversation

mndonx
Copy link
Contributor

@mndonx mndonx commented Nov 18, 2023

READY FOR REVIEW

Summary

This PR disables the module the uses the admin theme for the user login page and adjusts the theming to improve the page's appearance.

Urgency

medium

Steps to Test

  1. Visit the user login page, like https://hs-colorful.suhumsci.loc/user/login
  2. Ensure that the page is using the custom theme, and not Gin Admin theme.
  3. Ensure the there is only one title, the box-shadows have been removed, and the title is black (and not a light gray.)

PR Checklist

@mndonx mndonx requested a review from cienvaras November 18, 2023 05:07
@cienvaras cienvaras changed the base branch from develop to fk-stnfd-sprint-39 November 20, 2023 01:41
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mndonx Module should be disabled in the Drupal config before removing it from composer.json. Actually, I thing we need to do the Drupal config part in this part and the module removal later in another PR, to prevent errors during install.

@mndonx mndonx requested a review from cienvaras November 20, 2023 06:01
@mndonx
Copy link
Contributor Author

mndonx commented Nov 20, 2023

@cienvaras Sorry about that, I added those lines back in the composer files and exported config. Ready for review again.

@mndonx mndonx mentioned this pull request Nov 20, 2023
@mndonx
Copy link
Contributor Author

mndonx commented Nov 20, 2023

@cienvaras I added a part two #1401 PR for removing the module after it has been disabled.

Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@cienvaras cienvaras merged commit c07e943 into fk-stnfd-sprint-39 Nov 20, 2023
1 check passed
@cienvaras cienvaras deleted the SHS-5095-login-ui branch November 20, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants