Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5086: Add delete local task for developer users #1409

Merged
merged 2 commits into from
Nov 27, 2023
Merged

SHS-5086: Add delete local task for developer users #1409

merged 2 commits into from
Nov 27, 2023

Conversation

cienvaras
Copy link
Collaborator

READY FOR REVIEW

Summary

  • Show delete local task for developer user, hide for all others

Need Review By (Date)

11/27

Urgency

medium

Steps to Test

  1. Visit nodes of different content types as an user with the "Developer" role. You should be able to see and use the "Delete" local task
  2. Repeat the test with a couple of other users with different roles. The "Delete" local task shouldn't be present

PR Checklist

@cienvaras cienvaras requested a review from hectorlj November 27, 2023 16:33
@cienvaras cienvaras self-assigned this Nov 27, 2023
@cienvaras cienvaras marked this pull request as ready for review November 27, 2023 16:41
hectorlj
hectorlj approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@hectorlj hectorlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look and function well!

The CircleCi issues are related to changes in the fk-stnfd-sprint-39 branch.

@cienvaras cienvaras merged commit c6f5283 into fk-stnfd-sprint-39 Nov 27, 2023
1 check failed
@cienvaras cienvaras deleted the shs-5086-add-delete-option-back branch November 27, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorlj hectorlj hectorlj approved these changes

Assignees

@cienvaras cienvaras

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cienvaras @hectorlj