Four Kitchens Release - Sprint 41 #1425

cienvaras · 2023-12-22T23:16:57Z

READY FOR REVIEW

Summary

SHS-5118: Implementation: Improve styling of the "Add to calendar" dropdown
SHS-5180: Regression: Link field should generate URL to file, not media entity
SHS-4998: Add hb-raised-cards--uniform-height as checkbox on collections
SHS-5178: Implementation: Update Ocean more link color
SHS-5179: Optimize mobile image sizes

Need Review By (Date)

01/15

Urgency

medium

Steps to Test

SHS-5118

Visit a page like https://dlcl.stanford.edu/events/french-speaking-worlds-rejane-senac (local copy: https://dlcl.suhumsci.loc/events/french-speaking-worlds-rejane-senac)
Verify that the theming adjustments match those in the Figma design.

SHS-5180

Create a flexible page
Add a postcard component
In the the postcard link field, add a link to an existing media file
Publish and save the new page
Navigate to the new page
Verify that the following roles can access the file:
a. Anonymous
b. Authenticated
c. Contributor
d. Author
e. Site Manager

SHS-4998

Create new Flexible Page
Click on the Add Component button
Add a Collection component
Verify that clicking the Raised Cards checkbox causes the Uniform Height checkbox to appear, already enabled.
Set the Items Per Row to 2
Disable the Uniform Height checkbox
Using the Add Component button in the Collection component, add 2 Postcard components
Add a paragraph or two to the first component and add only one line to the second component
Save the new page and navigate to it
Verify that the postcards are different heights, but still have the styling from the hb-raised-cards class
Edit the new page
Click on the Edit button on the Collection component
Enable the Uniform Height checkbox
Save the page and navigate to it
Verify that the postcards are now the same height and still have the styling from the hb-raised-cards class
Check existing content with Collection components. Content with Raised Cards enabled should have Uniform Height enabled as well. The following were used to test during development:

West site
1. Understanding Attitudes in the West (Raised Cards enabled)
2. Student Profiles (Raised Cards disabled)
Planning site
1. Department External Reviews (Raised Cards disabled)
2. Events (Raised Cards enabled)

SHS-5178

Set up local with archaeology and history sites, switched to HS Colorful theme, and using the Ocean color scheme.
Observe the link contrast on More links with arrows and ensure they pass the color contrast tests:
https://archaeology.suhumsci.loc/academics/field-experience
Ensure that links and more links in "wells" (beige background areas) pass contrast tests:
https://history.suhumsci.loc/people/caroline-winterer
Ensure buttons with a filled background pass contrast tests (including on hover):
https://archaeology.suhumsci.loc/events/distinguished-lecture-series/gathering-shadows-material-things
Ensure buttons with a white background pass contrast tests (including on hover):
See "SUNet Login" in the footer area on any page
Ensure "reset" button passes contrast tests (including on hover):
https://history.suhumsci.loc/events/upcoming-events
Ensure Pager link color contrast passes contrast tests:
https://history.suhumsci.loc/recent-news
Ensure that date cards have proper contrast:
https://history.suhumsci.loc/events/upcoming-events

SHS-5179

Visit a page like: https://southasia.suhumsci.loc/
Note that there is now a preset for the smallest width here where there was not before:
https://southasia.suhumsci.loc/admin/config/media/image-styles/manage/postcard_vertical_linked_465px_
Make sure that images with the right dimensions are being loaded when visiting a page with vertical linked postcards (e.g. Homepage).

Before:

PR Checklist

* fix(shs-5118): add to calendar theming * fix(shs-5118): removing stray border * fix(shs-5118): fixing theming for traditional version * fix(shs-5118): a11y updates to addtocal button

…ok (#1427)

…stnfd-sprint-41

…ons (#1429) * feat(shs-4998): create uniform height checkbox field * feat(shs-4998): create deploy hook to update existing hs_collection paragraphs * feat(shs-4998): Update uniform height conditional field settings and visibility * feat(shs-4998): add check to uniform height that both uniform height and raised cards is enabled

* fix(shs-5178): ocean theme contrast fixes * fix(shs-5178): a few more contrast fixes * fix(shs-5178): limiting changes to colorful theme * chore(shs-5178): Update compiled css files --------- Co-authored-by: Andrés Díaz Soto <[email protected]> Co-authored-by: Andrés Díaz Soto <[email protected]>

Co-authored-by: Andrés Díaz Soto <[email protected]>

pookmish · 2024-01-19T20:43:20Z

docroot/modules/humsci/hs_paragraph_types/hs_paragraph_types.deploy.php

@@ -0,0 +1,29 @@
+<?php


What is this file? i've never heard of a deploy.php file nor do I understand how the function is intended to be used. I don't find any documentation for deploy hooks.

If this is just a simple update hook, move it to an install or post_update file

@pookmish Deploy hooks are part of drush and are executed after the configuration is imported. There's more information here:

https://www.drush.org/12.x/deploycommand/

https://www.hashbangcode.com/article/drupal-9-different-update-hooks-and-when-use-them

We consider is the best way for cases like this, when the db updates depend on configuration that's exported in the same PR. However, if you consider that's better to use an update hook, please let us know and we can change it.

It looks like deploy hooks are only part of drush and not part of core. There is an issue in the queue to add them to core, but there's not a lot of traction on it. It seems really useful but I'm a little concerned it's only drush supported.

I agree with Joe. To add to that, we would have to modify the deployment process to add the drush command. Let's move it to an update/post_update hook.

@joegl @pookmish Done, PR ready for review again. Thanks!

…stnfd-sprint-41

pookmish

Just need to swap for a service.

pookmish · 2024-01-23T17:34:00Z

docroot/modules/humsci/hs_paragraph_types/hs_paragraph_types.install

+ */
+function hs_paragraph_types_update_10000() {
+  $config_directories = Settings::get('config_sync_directory');
+  $file_storage = new FileStorage($config_directories);


There is a service for this: config.storage

@pookmish Fixed.

fix(shs-5118): add to calendar theming (#1421)

53934ab

* fix(shs-5118): add to calendar theming * fix(shs-5118): removing stray border * fix(shs-5118): fixing theming for traditional version * fix(shs-5118): a11y updates to addtocal button

cienvaras added the don't merge label Dec 22, 2023

cienvaras self-assigned this Dec 22, 2023

hectorlj and others added 6 commits January 10, 2024 14:49

feat(shs-5180): update postcard media link permissions with update ho…

d9a8f4e

…ok (#1427)

Merge branch '10.0.7-release' of github.com:SU-HSDO/suhumsci into fk-…

251b57d

…stnfd-sprint-41

fix(shs-5179): adding missing style settings (#1430)

4d243ee

Co-authored-by: Andrés Díaz Soto <[email protected]>

fix: coding standards

d04de83

cienvaras marked this pull request as ready for review January 12, 2024 22:53

cienvaras assigned joegl and pookmish and unassigned cienvaras Jan 12, 2024

cienvaras requested review from pookmish and joegl January 12, 2024 22:54

pookmish requested changes Jan 19, 2024

View reviewed changes

Merge branch '10.0.7-release' into fk-stnfd-sprint-41

dabbdb6

cienvaras requested a review from pookmish January 22, 2024 15:30

hectorlj and others added 2 commits January 22, 2024 16:54

fix(shs-4998): move database changes in deploy hook into an update hook

4c7d365

Merge branch '10.0.7-release' of github.com:SU-HSDO/suhumsci into fk-…

bc997c7

…stnfd-sprint-41

cienvaras added Needs review and removed don't merge labels Jan 23, 2024

pookmish requested changes Jan 23, 2024

View reviewed changes

fix(shs-4998): use config.storage.sync in update function

37d1070

cienvaras requested a review from pookmish January 24, 2024 02:15

Base automatically changed from 10.0.7-release to develop January 24, 2024 19:37

cienvaras changed the base branch from develop to 10.1.1-release January 24, 2024 20:59

pookmish approved these changes Jan 26, 2024

View reviewed changes

pookmish merged commit ab3bea5 into 10.1.1-release Jan 26, 2024
7 of 8 checks passed

pookmish deleted the fk-stnfd-sprint-41 branch January 26, 2024 23:32

cienvaras mentioned this pull request Aug 19, 2024

SHS-5783 / SHS-5784: New Well Color for Collections #1602

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Four Kitchens Release - Sprint 41 #1425

Four Kitchens Release - Sprint 41 #1425

cienvaras commented Dec 22, 2023 •

edited

Loading

pookmish Jan 19, 2024

cienvaras Jan 22, 2024

joegl Jan 22, 2024

pookmish Jan 22, 2024

cienvaras Jan 23, 2024

pookmish left a comment

pookmish Jan 23, 2024

cienvaras Jan 24, 2024

Four Kitchens Release - Sprint 41 #1425

Four Kitchens Release - Sprint 41 #1425

Conversation

cienvaras commented Dec 22, 2023 • edited Loading

READY FOR REVIEW

Summary

Need Review By (Date)

Urgency

Steps to Test

SHS-5118

SHS-5180

SHS-4998

SHS-5178

SHS-5179

PR Checklist

pookmish Jan 19, 2024

Choose a reason for hiding this comment

cienvaras Jan 22, 2024

Choose a reason for hiding this comment

joegl Jan 22, 2024

Choose a reason for hiding this comment

pookmish Jan 22, 2024

Choose a reason for hiding this comment

cienvaras Jan 23, 2024

Choose a reason for hiding this comment

pookmish left a comment

Choose a reason for hiding this comment

pookmish Jan 23, 2024

Choose a reason for hiding this comment

cienvaras Jan 24, 2024

Choose a reason for hiding this comment

cienvaras commented Dec 22, 2023 •

edited

Loading