-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHS 5178 Ocean color scheme link contrast adjustments #1426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mndonx Works as expected. The only problem I see is that the new styles you added are also present in traditional and airy compiled CSS. Please make sure to wrap the new code in the hb-colorful
mixin to target only the colorful theme:
@include hb-colorful {
// New styles for Ocean color pairing.
}
@cienvaras Good call, I think I got them all. |
… SHS-5178-ocean-more-link
…i into SHS-5178-ocean-more-link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks!
READY FOR REVIEW
Summary
This PR adjusts a few different color contrast differences for the Ocean color scheme.
Urgency
medium
Steps to Test
https://archaeology.suhumsci.loc/academics/field-experience
https://history.suhumsci.loc/people/caroline-winterer
https://archaeology.suhumsci.loc/events/distinguished-lecture-series/gathering-shadows-material-things
See "SUNet Login" in the footer area on any page
https://history.suhumsci.loc/events/upcoming-events
https://history.suhumsci.loc/recent-news
https://history.suhumsci.loc/events/upcoming-events
PR Checklist