Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS 5178 Ocean color scheme link contrast adjustments #1426

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

mndonx
Copy link
Contributor

@mndonx mndonx commented Dec 28, 2023

READY FOR REVIEW

Summary

This PR adjusts a few different color contrast differences for the Ocean color scheme.

Urgency

medium

Steps to Test

  1. Set up local with archaeology and history sites, switched to HS Colorful theme, and using the Ocean color scheme.
  2. Observe the link contrast on More links with arrows and ensure they pass the color contrast tests:
    https://archaeology.suhumsci.loc/academics/field-experience
  3. Ensure that links and more links in "wells" (beige background areas) pass contrast tests:
    https://history.suhumsci.loc/people/caroline-winterer
  4. Ensure buttons with a filled background pass contrast tests (including on hover):
    https://archaeology.suhumsci.loc/events/distinguished-lecture-series/gathering-shadows-material-things
  5. Ensure buttons with a white background pass contrast tests (including on hover):
    See "SUNet Login" in the footer area on any page
  6. Ensure "reset" button passes contrast tests (including on hover):
    https://history.suhumsci.loc/events/upcoming-events
  7. Ensure Pager link color contrast passes contrast tests:
    https://history.suhumsci.loc/recent-news
  8. Ensure that date cards have proper contrast:
    https://history.suhumsci.loc/events/upcoming-events

PR Checklist

@mndonx mndonx requested a review from cienvaras December 28, 2023 22:17
@cienvaras cienvaras changed the base branch from develop to fk-stnfd-sprint-41 January 8, 2024 17:28
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mndonx Works as expected. The only problem I see is that the new styles you added are also present in traditional and airy compiled CSS. Please make sure to wrap the new code in the hb-colorful mixin to target only the colorful theme:

@include hb-colorful {
  // New styles for Ocean color pairing.
}

@mndonx mndonx requested a review from cienvaras January 11, 2024 16:10
@mndonx
Copy link
Contributor Author

mndonx commented Jan 11, 2024

@cienvaras Good call, I think I got them all.

Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks! :shipit:

@cienvaras cienvaras merged commit dbf0495 into fk-stnfd-sprint-41 Jan 11, 2024
4 of 7 checks passed
@cienvaras cienvaras deleted the SHS-5178-ocean-more-link branch January 11, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants