Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5182: Warbler button styles/utility class button styles update #1437

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

cienvaras
Copy link
Collaborator

READY FOR REVIEW

Summary

  • Update styles of .hs-button and .hs-secondary-button utility classes in warbler color scheme to ensure that they looks as expected in all cases
  • Fix styles of table header links in warbler color scheme

Need Review By (Date)

01/26

Urgency

medium

Steps to Test

  1. Install the sociology site
  2. Visit the Traditional theme settings and change the color pairing to "Warbler"
  3. Visit the "PHD Placement Table" display of the "Sociology People" view config page, click on the "Settings" link in the "Format" section and make the "PhD Year" column sortable.
    Screenshot 2024-01-24 at 17 00 58
  4. Click on the "Content: Link to edit Content (Edit)" link in the "Fields" section, go to "Style Settings" and change the CSS class to hs-button
  5. Save the view.
  6. Visit the PhD Placements page and confirm the following:
    a. The "PhD Year" label in the heading table is a link and its color is white
    b. The "edit" button text is white in all cases
    Screenshot 2024-01-24 at 17 06 52
  7. Edit the view config page again and change back the "Content: Link to edit Content (Edit)" field class to hs-secondary-button. Go back to the PhD Placements page and confirm that the "edit" button text is white on hover.

PR Checklist

@cienvaras cienvaras self-assigned this Jan 24, 2024
@cienvaras cienvaras changed the base branch from develop to fk-stnfd-sprint-42 January 24, 2024 23:11

@include hb-traditional {
.ht-pairing-warbler & {
color: white !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you had no other option but to use !important here... this site is so hard for overrides.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, overrides in this case are hard, the clases used for setting the colors are really specific 🤷🏽‍♂️

Copy link
Contributor

@mndonx mndonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cienvaras Everything works as expected except for the focus state on the secondary button style - for me it is showing white text on white background. Otherwise, looks good!

@mndonx mndonx added bug Something isn't working and removed Needs review labels Jan 25, 2024
@cienvaras
Copy link
Collaborator Author

@mndonx Thanks! It's fixed now, I thought that the focus styles matched the hoves ones, but that's not the case. It should work now.

@cienvaras cienvaras requested a review from mndonx January 25, 2024 23:00
@cienvaras cienvaras added Needs review and removed bug Something isn't working labels Jan 25, 2024
@cienvaras cienvaras merged commit ea84a59 into fk-stnfd-sprint-42 Jan 26, 2024
7 of 8 checks passed
@cienvaras cienvaras deleted the shs-5182--warbler-buttons-fix branch January 26, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants