-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHS-5182: Warbler button styles/utility class button styles update #1437
Conversation
|
||
@include hb-traditional { | ||
.ht-pairing-warbler & { | ||
color: white !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing you had no other option but to use !important here... this site is so hard for overrides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, overrides in this case are hard, the clases used for setting the colors are really specific 🤷🏽♂️
docroot/themes/humsci/humsci_basic/src/scss/components/_buttons.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cienvaras Everything works as expected except for the focus state on the secondary button style - for me it is showing white text on white background. Otherwise, looks good!
Co-authored-by: Amanda Luker <amanda@fourkitchens.com>
… shs-5182--warbler-buttons-fix
@mndonx Thanks! It's fixed now, I thought that the focus styles matched the hoves ones, but that's not the case. It should work now. |
READY FOR REVIEW
Summary
.hs-button
and.hs-secondary-button
utility classes in warbler color scheme to ensure that they looks as expected in all casesNeed Review By (Date)
01/26
Urgency
medium
Steps to Test
hs-button
a. The "PhD Year" label in the heading table is a link and its color is white
b. The "edit" button text is white in all cases
hs-secondary-button
. Go back to the PhD Placements page and confirm that the "edit" button text is white on hover.PR Checklist