Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH-3160: Update carousel controls placement #1438

Merged
merged 7 commits into from
Jan 26, 2024

Conversation

cienvaras
Copy link
Collaborator

READY FOR REVIEW

Summary

This PR fixes the carousel controls placements on the traditional and colorful theme

Urgency

low

Steps to Test

  1. Log in to hs_traditional and hs_colorful locally.
  2. Visit a carousel, such as on one of the example pages below
  3. Confirm the following behavior is happening:
    • On Traditional theme, dot navigation should be horizontally aligned with arrow navigation, same as it is on Colorful theme.
    • Arrow navigation should always stay at same distance from bottom right edges of the container and not jump outside.

Traditional:
https://politicalscience.stanford.edu/
Current HP:
1

Mobile:
2

Colorful:
https://religiousstudies.stanford.edu/
Current HP:
3

Mobile:
4

PR Checklist

@cienvaras
Copy link
Collaborator Author

Original PR: #1422 - A new PR was created to include only the commits related to this ticket and exclude other commits from Sprint 41 release.

@cienvaras cienvaras merged commit c5fd97d into fk-stnfd-sprint-42 Jan 26, 2024
2 of 7 checks passed
@cienvaras cienvaras deleted the shs-3160--fix-carousel-controls branch January 26, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant