Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5228: Correct heading levels in views cards #1439

Merged
merged 1 commit into from
Jan 26, 2024
Merged

SHS-5228: Correct heading levels in views cards #1439

merged 1 commit into from
Jan 26, 2024

Conversation

cienvaras
Copy link
Collaborator

@cienvaras cienvaras commented Jan 26, 2024 •
edited
Loading

READY FOR REVIEW

Summary

  • Fix regex used for detecting headings in views cards

Need Review By (Date)

01/26

Urgency

medium

Steps to Test

  1. Install the dlcl site
  2. Visit https://dlcl.suhumsci.loc/people/faculty
  3. Confirm that the people names are wrapped in an <h4> heading and that it's not nested in another heading

PR Checklist

@cienvaras cienvaras merged commit 6c60734 into fk-stnfd-sprint-42 Jan 26, 2024
7 of 8 checks passed
@cienvaras cienvaras deleted the shs-5228--fix-views-card-headings branch January 26, 2024 23:06
@pookmish pookmish mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cienvaras