Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-3750: Breakout Box does not span the full width #1449

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

cienvaras
Copy link
Collaborator

READY FOR REVIEW

Summary

Make elements with hs-breakout-box full width

Need Review By (Date)

02/09

Urgency

medium

Steps to Test

  1. Create a Flexible page. In the text area, add some paragraphs with different lengths (at least one of them should be shorter than a full line, just some words).
  2. Apply the "Breakout Box" style to some of the paragraphs, using the CKEditor "Style" selector.
  3. Make sure that the Breakout Box background spans the full editor width, even when the text is shorter than a line.
  4. Save the node. Confirm that the Breakout Box background spans the full container width, even when the text is shorter than a line.

PR Checklist

@cienvaras cienvaras requested a review from mariannuar February 8, 2024 16:38
@cienvaras cienvaras self-assigned this Feb 8, 2024
Copy link
Collaborator

@mariannuar mariannuar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cienvaras Looks great!!

@cienvaras cienvaras merged commit 1c59bf2 into fk-stnfd-sprint-43 Feb 8, 2024
7 of 8 checks passed
@cienvaras cienvaras deleted the shs-3750--breakout-box-full-width branch February 8, 2024 19:14
@pookmish pookmish mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants