SHS-4047: A11y: Adjust slide transition based on user's Reduced Motion Preference #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… SHS-4047-a11y-adjust-slide-transition
mariannuar
commented
Feb 8, 2024
Comment on lines
13
to
19
| $(slickInstance).on('beforeChange', (event, slick) => { | ||
| slick.slickSetOption('cssEase', 'none', true); | ||
| }); | ||
| } else { | ||
| $(slickInstance).on('beforeChange', (event, slick) => { | ||
| slick.slickSetOption('cssEase', 'ease', true); | ||
| }); |
There was a problem hiding this comment.
While testing more, I found out the library already does this by default (remove animations at all). Test in a different branch/env.
There was a problem hiding this comment.
There was a problem hiding this comment.
Here's how it looks with the fade transition https://www.loom.com/share/60fb89ed8d80476da5dec32de826b5f8?sid=16e771f5-96cb-4796-a1c0-da7c8edfd068
… SHS-4047-a11y-adjust-slide-transition
cienvaras
requested changes
Feb 9, 2024
There was a problem hiding this comment.
@mariannuar Works great! Just fix a minor coding issue and we're done 🙂
| (function ($, Drupal, window) { | ||
| Drupal.behaviors.mySlickBehavior = { | ||
| // eslint-disable-next-line no-unused-vars | ||
| attach(context, settings) { |
There was a problem hiding this comment.
If you're not using the settings argument, just remove it. That way you don't need the eslint-disable
…-HSDO/suhumsci into SHS-4047-a11y-adjust-slide-transition
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Need Review By (Date)
02/09
Urgency
medium
Steps to Test
System Settings>Accessibility>DisplayBanner Image(s) with Partial Overlay (with multiple slides)
Banner Image(s) with Text Box (with multiple slides)
Spotlight (with multiple slides)
Photo Album (in Slider mode)
PR Checklist