Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSD8-1572: Add photo ID to local event image filename #1498

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

joegl
Copy link
Contributor

@joegl joegl commented Apr 8, 2024

READY FOR REVIEW

Summary

  • Add photo ID to local event image filename
  • This will create a new image if the event photo changes and prevent long-term caching when an event photo changes
  • I also added a trim (substr) on the urlname to 220 characters just to ensure there's enough characters left in the filename for the photo_id and file extension.

Example filenames from my local:

2024_undergraduate_honors_thesis_exhibition_45950742953656.jpg
8th-annual-berkeley-stanford-graduate-symposium-the-fog-comes-and-then-moves-on-on-transience-and-translucence_46014625790837.jpg
art-art-history-open-house-for-new-admits-and-families_46111611068927.jpg
christensen_distinguished_lecture_michael_boyce_gillespie_45526262322317.jpg

Need Review By (Date)

['10/30', 'asap', etc.]

Urgency

['low', 'medium', 'high', etc.]

Steps to Test

  1. [First testing step]
  2. ...

PR Checklist

@joegl joegl changed the base branch from develop to 10.1.9-release April 8, 2024 19:59
@joegl joegl requested a review from pookmish April 9, 2024 19:51
Copy link
Member

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a good improvement

plugin: substr
source: urlname
start: 0
length: 220
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some really long names?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some were getting pretty long yea lol. The file extension + photo id is about 20 characters.

@joegl joegl merged commit f48c3bb into 10.1.9-release Apr 10, 2024
13 of 15 checks passed
@joegl joegl deleted the HSD8-1572--add-localist-photoid-to-filename branch April 10, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants