Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5515: Refactor vertical card main link code #1505

Merged
merged 1 commit into from
Apr 17, 2024
Merged

SHS-5515: Refactor vertical card main link code #1505

merged 1 commit into from
Apr 17, 2024

Conversation

cienvaras
Copy link
Collaborator

READY FOR REVIEW

Summary

  • Refactor code for handing vertical card main link, as requested in FK Release 47 PR
  • Fix issue with special characters in stage reported by @ahughes3

NOTE: Special character issue was being caused by DOMElement saveHTML() encoding error. Removing DOMElement automatically fixes the issue.

Need Review By (Date)

  • 04/17

Urgency

high

Steps to Test

  1. Install english site
  2. Visit https://english.suhumsci.loc/people/faculty
  3. Confirm that you can click anywhere on the card and you'll be redirected to the person profile
  4. Confirm that names containing special characters (e.g. Ramón Saldívar) are being displayed correctly

PR Checklist

@cienvaras cienvaras requested a review from joegl April 17, 2024 02:15
@joegl joegl merged commit d5a8121 into 10.1.9-release Apr 17, 2024
15 checks passed
@joegl joegl deleted the shs-5515--vertical-card-fixes branch April 17, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joegl joegl joegl approved these changes

Assignees

@joegl joegl

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cienvaras @joegl