SHS-5582: Bug: Issue with Add/Select Media form field #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cienvaras
requested changes
Apr 26, 2024
There was a problem hiding this comment.
@mariannuar Thanks! Some fixes needed though, please check the inline comments.
docroot/themes/humsci/humsci_basic/src/scss/admin/_wysiwyg-editor.scss
Outdated
Show resolved
Hide resolved
docroot/themes/humsci/humsci_basic/src/scss/admin/_wysiwyg-editor.scss
Outdated
Show resolved
Hide resolved
|
@cienvaras Thank you for your feedback! Now the preact plugin is looking similar to the regular select. |
cienvaras
requested changes
Apr 29, 2024
There was a problem hiding this comment.
@mariannuar We're almost there, but there are still some inconsistencies that can be easily fixed:
- Label's line height should be 18px
- Button's vertical padding should be 7px, instead of 8px
- Border radius is smaller than other elements
Please use Gin CSS variables when available.
| @@ -97,4 +97,4 @@ drupal-media { | |||
| // it causes overflow into the next column | |||
| .ck-editor .ck.ck-toolbar.ck-toolbar_grouping > .ck-toolbar__items { | |||
| flex-wrap: wrap; | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Please remove this change.
| body.gin--edit-form .views-exposed-form .select-preact div > div > div:first-of-type { | ||
| font-size: 0.875rem !important; | ||
| font-weight: 525 !important; | ||
| color: #222330; |
There was a problem hiding this comment.
Gin has variables for most if its properties, please use them when available. In this case, var(--gin-color-title).
|
@cienvaras Thanks! Using gin variables now. |
cienvaras
approved these changes
May 2, 2024
cienvaras
added
Passes code review
Passes functional review
and removed
Needs review
labels
joegl
pushed a commit
that referenced
this pull request
May 6, 2024
* SHS-5608: Collection: Title Settings field updates (#1512) * SHS-5582: Bug: Issue with Add/Select Media form field (#1511) * SHS-5613: Bug: Vertical Link Cards with /media/{id} URLs not showing URL to file (#1518) * SHS-5574: Implementation: Refactor some grid CSS/mixins (#1508) * SHS-5571: A11y Level A: Empty headings on Vertical Timeline components (#1502) * SHS-5568: Allow editors to select style on Accordion component (#1501) * SHS-5583: empty headings in banners and spotlights (#1510) * SHS-5612: Implementation: Vertical Linked Card Title/Arrow Updates (#1513)
cienvaras
added a commit
that referenced
this pull request
May 16, 2024
* SHS-5608: Collection: Title Settings field updates (#1512) * feat(shs-5608): update hs_collection title settings field * feat(shs-5608): open hs collections title settings link in new tab --------- Co-authored-by: Andrés Díaz Soto <[email protected]> * SHS-5582: Bug: Issue with Add/Select Media form field (#1511) * fix(shs-5582): issue with Add/Select Media form field * fix(shs-5582): make the preact-select look like the default one * fix(shs-5582): fix more styles * feat(shs-5582): use gin variables * feat(shs-5582): use gin variables --------- Co-authored-by: Mari Núñez <[email protected]> * SHS-5613: Bug: Vertical Link Cards with /media/{id} URLs not showing URL to file (#1518) * feat: fix handling of Drupal Routes in basic theme * feat: remove unused use statements * feat(shs-5623): updates on date stacked vertical card * feat(shs-5623): reuse same code * fix(shs-5623): more fixes --------- Co-authored-by: Hector Lopez <[email protected]> Co-authored-by: Andrés Díaz Soto <[email protected]> Co-authored-by: Mari Núñez <[email protected]>
joegl
pushed a commit
that referenced
this pull request
May 20, 2024
* SHS-5623: Update styles for Date Stacked Vertical Card pattern (#1519) * SHS-5608: Collection: Title Settings field updates (#1512) * SHS-5582: Bug: Issue with Add/Select Media form field (#1511) * SHS-5613: Bug: Vertical Link Cards with /media/{id} URLs not showing URL to file (#1518) * SHS-5626: Implementation: New Accordion Style (FED) (#1525) * SHS-5581: Remove Chosen plugin dependency (#1530)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Fix the "Sort by" label and form field that has incorrect styling when site editor uses the Media Library in CKEditor
Need Review By (Date)
04/03
Urgency
low
Steps to Test
PR Checklist