Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSD8-1664: Updated PR template #1685

Merged
merged 3 commits into from
Dec 19, 2024
Merged

HSD8-1664: Updated PR template #1685

merged 3 commits into from
Dec 19, 2024

Conversation

joegl
Copy link
Contributor

@joegl joegl commented Nov 19, 2024 •
edited
Loading

READY FOR REVIEW

Summary

  • Working on a new PR template.
  • Is there anything else you'd like to see in it?

@ahughes3 ahughes3 temporarily deployed to Tugboat November 19, 2024 17:13 Destroyed
dalin-
dalin- reviewed Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@dalin- dalin- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions, but I don't have skin in the game so I'll neither approve nor block.

.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
@ahughes3 ahughes3 temporarily deployed to Tugboat November 19, 2024 18:46 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 19, 2024 18:49 Destroyed
Base automatically changed from 11.5.2-release to develop November 20, 2024 16:11
cienvaras
cienvaras approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes! And definitely adding phpcs to the CI pipeline is an improvement.

@joegl joegl changed the base branch from develop to 11.6.1-release November 22, 2024 15:37
@joegl joegl changed the title HSD8-16664: Updated PR template HSD8-1664: Updated PR template Nov 22, 2024
ahughes3
ahughes3 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ahughes3 ahughes3 requested a review from sethprime December 10, 2024 17:29
sethprime
sethprime reviewed Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@sethprime sethprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's here is good. Would it be worthwhile to add a frontend validation section for the PR reviewer?

sethprime
sethprime approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@sethprime sethprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ahughes3 ahughes3 assigned pookmish and unassigned sethprime Dec 17, 2024
@pookmish pookmish merged commit 0f44254 into 11.6.1-release Dec 19, 2024
15 of 16 checks passed
@pookmish pookmish deleted the HSD8-1664--update-pr-template branch December 19, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdyoung3 mdyoung3 mdyoung3 left review comments

@dalin- dalin- dalin- left review comments

@sethprime sethprime sethprime approved these changes

@cienvaras cienvaras cienvaras approved these changes

@ahughes3 ahughes3 ahughes3 approved these changes

@jbickar jbickar Awaiting requested review from jbickar

@codechefmarc codechefmarc Awaiting requested review from codechefmarc

@pookmish pookmish Awaiting requested review from pookmish

Assignees

@pookmish pookmish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joegl @ahughes3 @dalin- @cienvaras @sethprime @mdyoung3 @pookmish