Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SH-5972: Use default Drupal layouts in Dashboard #1697

Merged

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Dec 12, 2024

READY FOR REVIEW

Summary

Update logic in hs_layouts.module to use default Drupal layouts in Dashboards instead of the onces used in the FE

Urgency

medium

Steps to Test

  1. Go to https://pr1697-pksvk1y2mlhnkwglqkecukewc9y0oft0.tugboatqa.com/admin/structure/dashboard/experimental_dashboard/preview
  2. Edit layout
  3. Add a section and confirm there are only four layouts (1 Col, 2 Cols, 3 Cols, 4 Cols) that can be used in Dasboard
  4. Add any of them and confirm they look good (there will another ticket to make it looks better, once there's a design)
  5. Go to any page in the site (for example /accordions/accordions-secondary)
  6. Confirm the same custom layouts can be used and not the default by Drupal

PR Checklist


@ahughes3 ahughes3 temporarily deployed to Tugboat December 12, 2024 22:22 Destroyed
@mariannuar mariannuar self-assigned this Dec 12, 2024
@mariannuar mariannuar requested a review from cienvaras December 12, 2024 22:45
…humsci into shs-5972-use-default-drupal-layouts
@ahughes3 ahughes3 temporarily deployed to Tugboat December 14, 2024 00:30 Destroyed
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar That's a good start, just added some notes for doing the implementation more robust and clear.

docroot/modules/humsci/hs_layouts/hs_layouts.module Outdated Show resolved Hide resolved
@ahughes3 ahughes3 temporarily deployed to Tugboat December 16, 2024 20:46 Destroyed
@mariannuar mariannuar requested a review from cienvaras December 16, 2024 21:57
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Almost there, just a couple of things to fix.

docroot/modules/humsci/hs_layouts/hs_layouts.info.yml Outdated Show resolved Hide resolved
docroot/modules/humsci/hs_layouts/hs_layouts.module Outdated Show resolved Hide resolved
docroot/modules/humsci/hs_layouts/hs_layouts.module Outdated Show resolved Hide resolved
@ahughes3 ahughes3 temporarily deployed to Tugboat December 17, 2024 17:20 Destroyed
@mariannuar
Copy link
Collaborator Author

@cienvaras Done!

@mariannuar mariannuar requested a review from cienvaras December 17, 2024 17:37
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Only one change needed.

docroot/modules/humsci/hs_layouts/hs_layouts.info.yml Outdated Show resolved Hide resolved
@ahughes3 ahughes3 temporarily deployed to Tugboat December 17, 2024 17:58 Destroyed
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Thanks, looks good. Merging into the longterm dashboard branch.

@cienvaras cienvaras merged commit 81fcea4 into SHS-5913_Dashboard-initiative Dec 17, 2024
17 checks passed
@cienvaras cienvaras deleted the shs-5972-use-default-drupal-layouts branch December 17, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants