-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SH-5972: Use default Drupal layouts in Dashboard #1697
SH-5972: Use default Drupal layouts in Dashboard #1697
Conversation
…humsci into shs-5972-use-default-drupal-layouts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar That's a good start, just added some notes for doing the implementation more robust and clear.
…SDO/suhumsci into shs-5972-use-default-drupal-layouts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar Almost there, just a couple of things to fix.
@cienvaras Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar Only one change needed.
Co-authored-by: Andrés Díaz Soto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar Thanks, looks good. Merging into the longterm dashboard branch.
READY FOR REVIEW
Summary
Update logic in hs_layouts.module to use default Drupal layouts in Dashboards instead of the onces used in the FE
Urgency
medium
Steps to Test
PR Checklist