Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5988: Fix empty heading on postcards without title #1699

Open
wants to merge 2 commits into
base: 11.6.1-release
Choose a base branch
from

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Dec 17, 2024

READY FOR REVIEW

Summary

Fix empty heading on postcards without title

Urgency

medium

Steps to Test

  1. Go to https://hs-traditional-hjupmoiykro8of7nlzyvwahjo999gbjf.tugboatqa.com/components/collections-0/collections-postcards/vertical-cards/vertical-cards-raised-cards
  2. Scroll down to Vertical Postcards with Title, Image and Link in a Collection and Vertical Postcards with Title and Image in a Collection (first of the third row of cards)
  3. Confirm that if there isn't a title in the card, there isn't an h2 in the markup
  4. Please test this in other cards (in views too) by editing the card and removing the card title

PR Checklist

Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar LGTM!

@ahughes3 Ready for you to review

@cienvaras cienvaras requested a review from ahughes3 December 19, 2024 19:41
@cienvaras cienvaras assigned ahughes3 and unassigned mariannuar Dec 19, 2024
@cienvaras
Copy link
Collaborator

@ahughes3 Please take a look at this comment before approving the PR. The Chemistry site is not in Tugboat, but the existing links in the cards break after applying this fix. I think that the fix is still necessary, but descriptive titles should be added if they want to keep the links working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants