-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHS-5674: Help text for link fields is confusing #1702
Open
codechefmarc
wants to merge
7
commits into
11.6.1-release
Choose a base branch
from
SHS-5674--help-text
base: 11.6.1-release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cienvaras
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codechefmarc Looks great, just a minor code improvement suggestion.
docroot/modules/humsci/hs_field_helpers/hs_field_helpers.module
Outdated
Show resolved
Hide resolved
Ready to re-test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Need Review By (Date)
2025-01-08
Urgency
low
Steps to Test
Testing internal and external links
Testing external links only
Testing menu items and shortcuts
/admin/structure/menu/manage/main
/admin/config/user-interface/shortcut/manage/default/customize
Note: I did not find a field that used internal links only that wasn't the shortcut. So, to test, we can create a dummy field in a content type and set it to use internal links only. I did test this locally and it works fine:
PR Checklist