Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-6000: Stanford login font link changes #1705

Merged
merged 3 commits into from
Jan 13, 2025
Merged

SHS-6000: Stanford login font link changes #1705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bb865c
fix(shs-6000): fix stanford login font link
Jan 3, 2025
6cdd86b
fix(shs-6000): remove form_alter hook and update the formatting of su…
Jan 8, 2025
b4377cb
Merge branch 'develop' into shs-6000-fix-stanford-login-font-link
callinmullaney Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions docroot/modules/humsci/hs_admin/hs_admin.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,6 @@ function hs_admin_form_node_form_alter(&$form, FormStateInterface $form_state, $
];
}

/**
* Implements hook_form_FORM_ID_alter().
*/
function hs_admin_form_user_login_form_alter(&$form, FormStateInterface $form_state, $form_id) {
if (isset($form['saml']['#attributes']['class'])) {
$form['saml']['#attributes']['class'][] = 'simplesamlphp-auth-login-link';
}
}

/**
* After build callback for hs_admin_form_node_form_alter().
*
Expand Down
26 changes: 0 additions & 26 deletions docroot/themes/humsci/su_humsci_admin/scss/humsci_admin.portal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,32 +16,6 @@
padding: 30px;
}

.simplesamlphp-auth-login-link {
display: block;
font-size: 32px;
box-shadow: 0 2px 2px 0 rgba(0, 0, 0, 0.14), 0 1px 5px 0 rgba(0, 0, 0, 0.12), 0 3px 1px -2px rgba(0, 0, 0, 0.2);
padding: 10px;
position: relative;
color: #b1040e;

/* stylelint-disable font-family-no-missing-generic-family-keyword */
&::after {
content: '\f054';
font-family: 'Font Awesome 5 Free';
font-weight: 900;
font-style: normal;
font-variant: normal;
text-rendering: auto;
line-height: 1;
color: #9e9e9e;
position: absolute;
top: calc(50% - 10px);
font-size: 20px;
right: 20px;
}
/* stylelint-enable font-family-no-missing-generic-family-keyword */
}

h1 {
margin: 2.1rem 0 1.68rem;
font-weight: 200;
Expand Down
34 changes: 33 additions & 1 deletion docroot/themes/humsci/su_humsci_gin_admin/dist/su_humsci_gin_admin.portal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,33 @@
.content-header{background:transparent;text-align:center}.content-header,.layout-container{max-width:600px;margin:0 auto}.user-login-form h1{display:none}.simplesamlphp-auth-login-link{display:inline-block;font-size:32px;padding:30px 0;position:relative;color:#b1040e}.simplesamlphp-auth-login-link::after{content:'\f054';font-family:'Font Awesome 5 Free';font-weight:900;font-style:normal;font-variant:normal;text-rendering:auto;line-height:1;color:#9e9e9e;position:absolute;top:calc(50% - 10px);font-size:20px;right:-20px}
.content-header {
background: transparent;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the compiled css minified?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pookmish This was Andres' recommendation as using un-minified CSS to debug styling issues locally much easier without needing to manage multiple CSS compiling profiles based on the environment.
Screenshot 2025-01-13 at 3 10 37 PM

Also, because production and stage config are already being managed via config_split they enable CSS aggregation $config['system.performance']['css']['preprocess'] = TRUE; which minifies the CSS for us. So no need to minify things before they are sent to Drupal to be minified (again) and aggregated into a single file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I didn't see the comment and I noticed the diff in the changes. Just making sure that it's intentional. 👍

text-align: center;
}
.content-header,
.layout-container {
max-width: 600px;
margin: 0 auto;
}
.user-login-form h1 {
display: none;
}
.samlauth-login {
display: inline-block;
font-size: 32px;
padding: 30px 0;
position: relative;
color: #b1040e;
}
.samlauth-login::after {
content: "\f054";
font-family: "Font Awesome 5 Free";
font-weight: 900;
font-style: normal;
font-variant: normal;
text-rendering: auto;
line-height: 1;
color: #9e9e9e;
position: absolute;
top: calc(50% - 10px);
font-size: 20px;
right: -20px;
}
Loading