SHS-5954: Social Media Footer block — allow mailto: links #1706
Conversation
There was a problem hiding this comment.
@codechefmarc Works great, thanks!
@ahughes3 This one is ready for you, but tugboat is over quota so no test environment available yet. As soon as some older PR's get approved and merged we'll be able to create a test link.
|
@cienvaras I rebuilt some of the older PRs in Tugboat which reduced their size by a few gigs and was able to get the previews for this PR built. Thank you! |
…humsci into SHS-5954--social-allow-mailto
|
@pookmish - Ready for re-review. Thanks. |
docroot/modules/humsci/hs_blocks/src/Plugin/Block/SocialMediaBlock.php
Outdated
Show resolved
Hide resolved
| if (str_starts_with($value, 'mailto')) { | ||
| if (!preg_match($mailto_regex, $value)) { |
There was a problem hiding this comment.
One of the problems here is that if someone enters in mailto: with an invalid email address, that case will not be caught and instead will be validated as a URL. I can change so we don't get any custom messaging for invalid mailto links and combine if you wish.
READY FOR REVIEW
Summary
Allows
mailto:links in addition to standard URLs for social media block.Need Review By (Date)
2025-01-08
Urgency
low
Steps to Test
/admin/structure/blockand placing the "Social Media Block" in the footer, for example.mailto:[email protected]linkmailtoor URLs and verify there are correct error messages for the user.PR Checklist