SHS-6103: ARIA - "ARIA attribute unsupported or prohibited" in Vertical Timelines

[mariannuar]

Summary

Fix aria attributes in Vertical Timelines

Need Review By (Date)

03/12

Urgency

medium

Steps to Test

1. Go to https://pr1766-oul53tg46g49olxd2awym2ihyx59xlac.tugboatqa.com/components/vertical-timeline-without-and-collection
2. Test by using a screen reader and keyboard navigation, and confirm everything is working well.
3. Note: Aria attributes are not necessary when using <details> and <summary> in the markup

Review Tasks

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Are PHP functions and variables in snake_case and not camelCase?
• Does Drupal code follow Drupal Coding Standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided?

Code security

• Is all user input properly sanitized when rendered?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1209575176449739

[cienvaras]

@mariannuar Looks good! Just a minor fix needed.

[mariannuar]

@cienvaras Ready for review again!

[cienvaras]

@mariannuar LGTM!

@ahughes3 Ready for you

[ahughes3]

@cienvaras @mariannuar Is Step #3 in the testing instructions correct? I was't sure if it was incomplete or if it was something specific to screen readers

[mariannuar]

@ahughes3 Oh step 3 is more like a note about that there are not longer aria attributes since they are not necessary for those tags. GitHub kind of create like an accordion instead of adding the tags I was refering to. Sorry about that.

[ahughes3]

Tugboat has finished building the preview for this pull request!

Links:

• https://pr1766-oul53tg46g49olxd2awym2ihyx59xlac.tugboatqa.com
• https://hs-colorful-oul53tg46g49olxd2awym2ihyx59xlac.tugboatqa.com
• https://hs-traditional-oul53tg46g49olxd2awym2ihyx59xlac.tugboatqa.com
• https://history-oul53tg46g49olxd2awym2ihyx59xlac.tugboatqa.com
• https://west-oul53tg46g49olxd2awym2ihyx59xlac.tugboatqa.com

Dashboard:

• https://dashboard.tugboatqa.com/67c5d341b18a3c1feb06a260

Visual Diffs:

• https://dashboard.tugboatqa.com/67c5d341b18a3c1feb06a260/visualdiffs