Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angi devel - remove legacy tools - commands and old perl library #281

Merged
merged 13 commits into from
Feb 20, 2025

Conversation

fmherschel
Copy link
Member

These tools have been added to the package by error and must be removed to avoid confusion:

  • tools/SAPHanaSR-filter-legacy
  • tools/SAPHanaSR-monitor-legacy
  • tools/SAPHanaSR-replay-archive-legacy
  • tools/SAPHanaSR-showAttr-legacy
  • tools/SAPHanaSRTools.pm

Copy link
Collaborator

@lpinne lpinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me

@fmherschel
Copy link
Member Author

Just (late) used the chance also to update the copyright entry to be expanded to 2025.

@fmherschel fmherschel requested a review from lpinne February 20, 2025 11:21
Copy link
Collaborator

@angelabriel angelabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do not need perl anymore, we should remove the require

Copy link
Collaborator

@angelabriel angelabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After clarifying the perl stuff everything looks good to me, thanks

@fmherschel fmherschel merged commit 4264772 into SUSE:main Feb 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants