Add /health.json and /instances.json #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
- Coverage 84.47% 84.35% -0.13%
==========================================
Files 28 28
Lines 2384 2391 +7
==========================================
+ Hits 2014 2017 +3
- Misses 370 374 +4
Continue to review full report at Codecov.
|
Add instances.json path to query all currently known instances as json object.
grisu48
changed the title
grisu48
changed the title
|
Codecod complains because I introduced new http methods in a class, which is also not covered by any other tests before. |
|
Poking @asmorodskyi again to review this PR. |
|
cool idea and nice implementation 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
/instances.jsonpath to query all currently known instances as json object and/health.jsonto query the health of the instance. Both are required for CLI tools to query the instance without using the WebUI.This PR addresses #124