When migrating compare product classes #1281
Conversation
Because of the change from SLE Micro < 6.0 to SL Micro 6+ comparing the identifier no longer works when migrating This fixes bsc#1236816
| @@ -122,7 +122,7 @@ def verify_base_product_upgrade | |||
|
|
|||
| activated_bases = @system.products.where(product_type: 'base') | |||
| activated_bases.each do |base_product| | |||
| return true if (base_product.identifier == upgrade_product.identifier) | |||
| return true if base_product.product_class == upgrade_product.product_class | |||
There was a problem hiding this comment.
Maybe base_product.identifier == upgrade_product.identifier || base_product.product_class == upgrade_product.product_class is more safe.
There was a problem hiding this comment.
I considered that option but isn't product_identifer matching a subset of product_class matching ?
There was a problem hiding this comment.
The product identifier can change across versions (as happened with Micro), but also the product class can change. So the suggested condition would be more safe.
In the end what we do here is a hack because it's not based on the subscription. In SCC, the migration would check if the target product is included in the system's subscription.
There was a problem hiding this comment.
OK, so, similar to the issue with SUMA ARM64, a better check on subscription is recommended/encouraged
I will do that instead of the double hack (product identifier + product class)
Thoughts ?
There was a problem hiding this comment.
In general, it would be useful if you have a way also for PAYG to find out the used subscription, to use it's settings to determine which products a system should have access to.
There was a problem hiding this comment.
yes, the fix/new check would be for PAYG as well
Description
Because of the change from SLE Micro < 6.0 to SL Micro 6+ comparing the identifier no longer works when migrating
This fixes bsc#1236816
How to test
Start a Micro 5.5 instance, run
transactional-update migration, choose any of the available options, i.e.Available migrations: 1 |SUSE Linux Micro 6.1 x86_64 2 |SUSE Linux Micro 6.0 x86_64 [num/q]: 1Migration should succeed
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Review
Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.