Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching to slog #28

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Switching to slog #28

merged 3 commits into from
Jul 10, 2024

Conversation

gbuenodevsuse
Copy link
Collaborator

Adresses #15

@gbuenodevsuse gbuenodevsuse requested review from mbelur and rtamalin July 5, 2024 15:18
@gbuenodevsuse gbuenodevsuse changed the title switching to slog Switching to slog Jul 5, 2024
@gbuenodevsuse gbuenodevsuse self-assigned this Jul 8, 2024
rtamalin
rtamalin requested changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@rtamalin rtamalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, spotted a minor typo with suggested fix.

pkg/lib/processor.go Outdated Show resolved Hide resolved
@gbuenodevsuse @rtamalin
Update pkg/lib/processor.go
819d8db 
Co-authored-by: Fergal Mc Carthy <[email protected]>
rtamalin
rtamalin requested changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@rtamalin rtamalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbuenodevsuse gbuenodevsuse requested a review from rtamalin July 9, 2024 22:33
rtamalin
rtamalin approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@rtamalin rtamalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbuenodevsuse gbuenodevsuse merged commit 9297eff into main Jul 10, 2024
1 check passed
@gbuenodevsuse gbuenodevsuse deleted the switch_to_slog_logging branch July 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtamalin rtamalin rtamalin approved these changes

@mbelur mbelur Awaiting requested review from mbelur

Assignees

@gbuenodevsuse gbuenodevsuse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbuenodevsuse @rtamalin